From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option. Date: Thu, 2 Mar 2017 08:44:48 +0100 Message-ID: <20170302084448.2ff6ce96@scratchpost.org> References: <20170219185431.zgn53ndcbpedrgo7@wasp> <20170220235355.29115-1-clement@lassieur.org> <20170220235355.29115-5-clement@lassieur.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjLQ2-0005jx-4U for guix-devel@gnu.org; Thu, 02 Mar 2017 02:44:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjLPz-00036t-2F for guix-devel@gnu.org; Thu, 02 Mar 2017 02:44:58 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:44246) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cjLPy-00035n-S9 for guix-devel@gnu.org; Thu, 02 Mar 2017 02:44:54 -0500 In-Reply-To: <20170220235355.29115-5-clement@lassieur.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?ISO-8859-1?Q?Cl=E9ment?= Lassieur Cc: guix-devel@gnu.org Hi, On Tue, 21 Feb 2017 00:53:55 +0100 Cl=C3=A9ment Lassieur wrote: > +This is a list of two-element tuples,=20 list of pairs. >where each tuple contains the each pair > +subsystem name and a command (with optional arguments) to execute upon > +subsystem request. > + > +The command @command{sftp-server} implements the SFTP file transfer > +subsystem. > +@example > +'(("sftp" "/usr/libexec/sftp-server")) Hmm, that is a list in there, not a two-element tuple: scheme@(guile-user)> (car '(("A" "B"))) $1 =3D ("A" "B") scheme@(guile-user)> (car (car '(("A" "B")))) $3 =3D "A" scheme@(guile-user)> (cdr (car '(("A" "B")))) $2 =3D ("B") <---- should be "B" without the parens for tuples So I suggest either fix the example to be a pair ("sftp" . "/usr/libexec/sf= tp-server") or fix the docs.