From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 3/4] services: openssh: Fix 'PrintLastLog' default
	behaviour.
Date: Thu, 2 Mar 2017 08:37:05 +0100
Message-ID: <20170302083705.57339ace@scratchpost.org>
References: <20170219185431.zgn53ndcbpedrgo7@wasp>
	<20170220235355.29115-1-clement@lassieur.org>
	<20170220235355.29115-4-clement@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cjLIW-0003yV-HL
	for guix-devel@gnu.org; Thu, 02 Mar 2017 02:37:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cjLIT-0000sA-EH
	for guix-devel@gnu.org; Thu, 02 Mar 2017 02:37:12 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:43855)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cjLIT-0000s2-7e
	for guix-devel@gnu.org; Thu, 02 Mar 2017 02:37:09 -0500
In-Reply-To: <20170220235355.29115-4-clement@lassieur.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?ISO-8859-1?Q?Cl=E9ment?= Lassieur <clement@lassieur.org>
Cc: guix-devel@gnu.org

Hi,

On Tue, 21 Feb 2017 00:53:54 +0100
Cl=C3=A9ment Lassieur <clement@lassieur.org> wrote:

> * gnu/services/ssh.scm (openssh-config-file): Add 'pring-last-log?' optio=
n.
                                                         ^ typo

>   (<openssh-configuration>)[print-last-log?]: Add it.
>   (openssh-activation): Touch /var/log/lastlog.

Indentation is too much here.

> * doc/guix.texi (Networking Services): Document 'pring-last-log?'.
                                                       ^ typo

> +      (let ((lastlog "/var/log/lastlog"))
> +        (when #$(openssh-configuration-print-last-log? config)
> +          (unless (file-exists? lastlog)
> +            (touch lastlog))))
> +

Hmm. What about the permissions? Are they OK?

Otherwise LGTM!