From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: gnu-patches back log Date: Wed, 1 Mar 2017 08:14:48 -0500 Message-ID: <20170301131448.GA13356@jasmine> References: <87inof5w20.fsf@dustycloud.org> <20170226111029.GA19050@mail.thebird.nl> <87poi4rd1m.fsf@dustycloud.org> <20170228062531.GA647@mail.thebird.nl> <20170301061625.GA11982@jasmine> <20170301081739.GA10117@mail.thebird.nl> <20170301111715.GA11182@mail.thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cj45t-0004md-0B for guix-devel@gnu.org; Wed, 01 Mar 2017 08:15:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cj45o-0008Cq-2U for guix-devel@gnu.org; Wed, 01 Mar 2017 08:15:00 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:56120) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cj45n-0008Bx-Ta for guix-devel@gnu.org; Wed, 01 Mar 2017 08:14:56 -0500 Content-Disposition: inline In-Reply-To: <20170301111715.GA11182@mail.thebird.nl> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Pjotr Prins Cc: guix-devel On Wed, Mar 01, 2017 at 11:17:15AM +0000, Pjotr Prins wrote: > I am not asking you in particular, but everyone in general, if you > feel like coaching one submission per week. That would take a load > of work away from Ricardo and Ludo and improve speed dramatically. Try running `git log --format=full` to see who is actually pushing commits. It's a significantly more diverse group than just Ricardo and Ludo. > This is the first thing I am trying :). The main difference with the > existing approach is that I want to have more engagement from fresh > contributors who can also peer review. Review is an excellent way of > learning. How exactly we are going to do this is not clear yet. But > that is what I am thinking. > > Meanwhile I want to know what limits people actually have. I think 2 > weeks is not acceptable (but that should be obvious). I'm sure that everyone would like for patches to be handled within two weeks, 3 days, etc. But, what operating system distribution actually does that? Guix is already one of the most accessible distributions for new contributors. Many of us are *at the limit* of what we can do for Guix. Describing our efforts as "embarrassing" (which you've done more than once) is demotivating. Please try something else. By the way, I know that at least several of us give special attention to patches from new contributors. We are aware of the effects of speedy (or slow) review. Plus, I almost never hear anyone talk about all the other important "boring" work that goes into the distribution: Package maintenance, security updates and vulnerability review, and bug triage. These are the other tasks we must balance against patch review. And after that, we can actually work on features and refactoring. And yet, I don't badger anyone to do more of that work, because I think that would actually make them *less interested* in doing it. If they skim the commit log and mailing lists, they'll know these tasks exist.