From: Leo Famulari <leo@famulari.name>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: Add jacal.
Date: Mon, 27 Feb 2017 19:31:11 -0500 [thread overview]
Message-ID: <20170228003111.GB14214@jasmine> (raw)
In-Reply-To: <1488138148-24017-3-git-send-email-jmd@gnu.org>
On Sun, Feb 26, 2017 at 08:42:28PM +0100, John Darrington wrote:
> * gnu/packages/maths.scm (jacal): New variable.
> * gnu/packages/patches/jacal.texi.patch: New file.
Can you rename the patch jacal-texi.patch (for consistency with the
majority of the patches) and add a comment in the patch file explaining
what it does?
> + (replace 'configure
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (zero? (system* "./configure"
> + (string-append "--prefix="
> + (assoc-ref outputs "out")))))))))
This can be done in #:configure-flags, right?
next prev parent reply other threads:[~2017-02-28 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 19:42 [PATCH 1/3] gnu: Add slib John Darrington
2017-02-26 19:42 ` [PATCH 2/3] gnu: Add scm John Darrington
2017-02-26 19:42 ` [PATCH 3/3] gnu: Add jacal John Darrington
2017-02-28 0:31 ` Leo Famulari [this message]
2017-02-28 6:10 ` John Darrington
2017-02-28 0:26 ` [PATCH 1/3] gnu: Add slib Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228003111.GB14214@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).