From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH 1/2] build: union: Add create-all-directory? parameter to union-build Date: Fri, 24 Feb 2017 15:02:56 +0100 Message-ID: <20170224150256.641cb08d@scratchpost.org> References: <20170218004427.12392-1-huang_ying_caritas@163.com> <87tw7jn4mo.fsf@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1chGSk-0007bi-Hg for guix-devel@gnu.org; Fri, 24 Feb 2017 09:03:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1chGSg-0000ip-Fx for guix-devel@gnu.org; Fri, 24 Feb 2017 09:03:10 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:41922) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1chGSg-0000dy-8V for guix-devel@gnu.org; Fri, 24 Feb 2017 09:03:06 -0500 In-Reply-To: <87tw7jn4mo.fsf@163.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: "Huang, Ying" Cc: guix-devel@gnu.org, Alex Kost Hi, yeah, I've looked at it and I see what you are trying to do. You modified 'union to replicate the directory tree and symlink only the non-directory files - in order to be able to add "fonts.dir" in those directories. The previous version symlinked entire directories, too, and you wouldn't have been able to add those "fonts.dir" files inside them later. Your fix seems kinda hacky - but I don't really see a downside. Thinking about it some more I think it looks good enough to me. I'd like a second opinion, though. Other than that, the name of the new flag "create-all-directory?" is weird. I'd like it to be something like "create-all-directories?". (The non-hacky solution would be to make 'union aware that there are "fonts.dir" files to go in there, too. One could do that by adding these as an input, too. I'm not sure whether that would be worth the added complexity, though - especially since the fonts.dir generator needs to have the finished union as input and not just single directories one by one. Thoughts?)