From: Julien Lepiller <julien@lepiller.eu>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add lmms
Date: Fri, 24 Feb 2017 11:56:15 +0100 [thread overview]
Message-ID: <20170224115615.126c56bd@polymos.lepiller.eu> (raw)
In-Reply-To: <583a6a7b3ffe64633b3009129c6dcba7@openmailbox.org>
On Thu, 23 Feb 2017 10:13:54 -0800
Rodger Fox <thylakoid@openmailbox.org> wrote:
> > It's a good idea to run "./pre-inst-env guix lint PACKAGENAME"
> > which will pick up long lines for example.
> > I have a ruler/colored line at character 83 in vim, but I'm not yet
> > ready with the setup to write correct code again in vim. There's
> > a similar thing for emacs.
> >
> > I would replace the third or second "It" with @code{LMMS} or simply
> > LMMS.
>
> Thanks for pointing that out. I missed that pre-inst-env tool in
> the manual until you just mentioned it here. That helps a lot.
> My corrected patch is attached. It passes the linter this time.
>
> -Rodger Fox
I've tested the patch, and it seems to work. One of the libraries
indeed cannot find its neighbor. I've loaded the functionality that is
enabled by it, and it works, but it may break at some point. Usually
runpath problems can be solved by passing "-Wl,runpath=" option to ld
during the make phase. Can you try it? Otherwise your patch is good.
next prev parent reply other threads:[~2017-02-24 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 18:13 [PATCH] gnu: Add lmms Rodger Fox
2017-02-24 10:56 ` Julien Lepiller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-09 4:47 Rodger Fox
2017-03-15 22:03 ` Leo Famulari
2017-03-17 5:54 ` Rodger Fox
2017-03-21 19:20 ` Leo Famulari
2017-03-21 19:39 ` Leo Famulari
[not found] <mailman.54228.1487857637.22740.guix-devel@gnu.org>
2017-02-23 16:38 ` Rodger Fox
2017-02-22 23:18 Rodger Fox
2017-02-23 9:15 ` julien lepiller
2017-02-23 11:30 ` ng0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224115615.126c56bd@polymos.lepiller.eu \
--to=julien@lepiller.eu \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).