[PATCH] gnu: inetutils: Enable tests.

[PATCH] gnu: inetutils: Enable tests.

[Maxim Cournoyer]

[-- Attachment #1.1: Type: text/plain, Size: 75 bytes --]

Hello Guix!

Here's a simple patch which enables the tests for inetutils.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-inetutils-Enable-tests.patch --]
[-- Type: text/x-patch, Size: 1981 bytes --]

From f707e5f479b2df969cbe582f722afbf761596ef3 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Date: Wed, 22 Feb 2017 09:03:25 -0800
Subject: [PATCH] gnu: inetutils: Enable tests.

* gnu/packages/admin.scm (inetutils)[source]: Indent.
[arguments]: Remove #:tests? and #:configure-flags (not needed).
[native-inputs]: Add net-tools as tests require netstat.
---
 gnu/packages/admin.scm | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index b2207a1205..2d6543e0f6 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -246,20 +246,16 @@ re-executing them as necessary.")
     (name "inetutils")
     (version "1.9.4")
     (source (origin
-             (method url-fetch)
-             (uri (string-append "mirror://gnu/inetutils/inetutils-"
-                                 version ".tar.gz"))
-             (sha256
-              (base32
-               "05n65k4ixl85dc6rxc51b1b732gnmm8xnqi424dy9f1nz7ppb3xy"))))
+              (method url-fetch)
+              (uri (string-append "mirror://gnu/inetutils/inetutils-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "05n65k4ixl85dc6rxc51b1b732gnmm8xnqi424dy9f1nz7ppb3xy"))))
     (build-system gnu-build-system)
-    (arguments `(#:configure-flags '("--localstatedir=/var")
-
-                 ;; FIXME: `tftp.sh' relies on `netstat' from utils-linux,
-                 ;; which is currently missing.
-                 #:tests? #f))
     (inputs `(("ncurses" ,ncurses)
-              ("readline" ,readline)))            ; for 'ftp'
+              ("readline" ,readline)))        ;for 'ftp'
+    (native-inputs `(("netstat" ,net-tools))) ;for tests
     (home-page "http://www.gnu.org/software/inetutils/")
     (synopsis "Basic networking utilities")
     (description
-- 
2.11.1


[-- Attachment #1.3: Type: text/plain, Size: 16 bytes --]


Thanks,

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] gnu: inetutils: Enable tests.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Wed, Feb 22, 2017 at 09:21:51AM -0800, Maxim Cournoyer wrote:
> Hello Guix!
> 
> Here's a simple patch which enables the tests for inetutils.

Sounds great!

> From f707e5f479b2df969cbe582f722afbf761596ef3 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> Date: Wed, 22 Feb 2017 09:03:25 -0800
> Subject: [PATCH] gnu: inetutils: Enable tests.
> 
> * gnu/packages/admin.scm (inetutils)[source]: Indent.
> [arguments]: Remove #:tests? and #:configure-flags (not needed).

I'm curious, what is the value of $localstatedir if we don't set it?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] gnu: inetutils: Enable tests.

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Hi Leo!

Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 22, 2017 at 09:21:51AM -0800, Maxim Cournoyer wrote:
>> Hello Guix!
>> 
>> Here's a simple patch which enables the tests for inetutils.
>
> Sounds great!
>
>> From f707e5f479b2df969cbe582f722afbf761596ef3 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 22 Feb 2017 09:03:25 -0800
>> Subject: [PATCH] gnu: inetutils: Enable tests.
>> 
>> * gnu/packages/admin.scm (inetutils)[source]: Indent.
>> [arguments]: Remove #:tests? and #:configure-flags (not needed).
>
> I'm curious, what is the value of $localstatedir if we don't set it?

I was under the (flawed) impression that the gnu build system would take
care of this detail for us. Luckily inetutils doesn't seem to require setting
this at all. I've studied the build log more closely and didn't see any
mention of localstatedir.

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH] gnu: inetutils: Enable tests.

[Ludovic Courtès]

Leo Famulari <leo@famulari.name> skribis:

> On Wed, Feb 22, 2017 at 09:21:51AM -0800, Maxim Cournoyer wrote:
>> Hello Guix!
>> 
>> Here's a simple patch which enables the tests for inetutils.
>
> Sounds great!
>
>> From f707e5f479b2df969cbe582f722afbf761596ef3 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Wed, 22 Feb 2017 09:03:25 -0800
>> Subject: [PATCH] gnu: inetutils: Enable tests.
>> 
>> * gnu/packages/admin.scm (inetutils)[source]: Indent.
>> [arguments]: Remove #:tests? and #:configure-flags (not needed).
>
> I'm curious, what is the value of $localstatedir if we don't set it?

By default it’s $prefix/var:

  https://www.gnu.org/prep/standards/html_node/Directory-Variables.html

Ludo’.