From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: python-pygame: Update to 1.9.3.
Date: Tue, 21 Feb 2017 14:14:30 -0500
Message-ID: <20170221191430.GA8544@jasmine>
References: <20170221175319.10067-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41195)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cgFtb-0004E5-N9
	for guix-devel@gnu.org; Tue, 21 Feb 2017 14:14:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cgFtW-0002sP-KJ
	for guix-devel@gnu.org; Tue, 21 Feb 2017 14:14:43 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35203)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cgFtV-0002rL-LD
	for guix-devel@gnu.org; Tue, 21 Feb 2017 14:14:38 -0500
Content-Disposition: inline
In-Reply-To: <20170221175319.10067-1-dannym@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Tue, Feb 21, 2017 at 06:53:19PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/game-development.scm (python-pygame)[version]: Update to 1.9.3.
>   [source]: Use pypi-uri.

These lines should start in the first column, not indented.

>   [inputs]: Add freetype.
>   [arguments]: Remove python-2. Substitute "FREETYPE".

I would write "Use python-3 instead of python-2". 

And I would write "Provide path to freetype library in
'set-library-paths' phase.

Otherwise, LGTM! Thanks!