unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: python-pygame: Update to 1.9.3.
Date: Tue, 21 Feb 2017 14:14:30 -0500	[thread overview]
Message-ID: <20170221191430.GA8544@jasmine> (raw)
In-Reply-To: <20170221175319.10067-1-dannym@scratchpost.org>

On Tue, Feb 21, 2017 at 06:53:19PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/game-development.scm (python-pygame)[version]: Update to 1.9.3.
>   [source]: Use pypi-uri.

These lines should start in the first column, not indented.

>   [inputs]: Add freetype.
>   [arguments]: Remove python-2. Substitute "FREETYPE".

I would write "Use python-3 instead of python-2". 

And I would write "Provide path to freetype library in
'set-library-paths' phase.

Otherwise, LGTM! Thanks!

  reply	other threads:[~2017-02-21 19:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 17:53 [PATCH] gnu: python-pygame: Update to 1.9.3 Danny Milosavljevic
2017-02-21 19:14 ` Leo Famulari [this message]
2017-02-22 10:32   ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170221191430.GA8544@jasmine \
    --to=leo@famulari.name \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).