Re: [PATCH 1/3] gnu: wxwidgets: Fix for Filezilla client.

[Leo Famulari <leo@famulari.name>]

On Thu, Feb 09, 2017 at 10:36:16AM -0600, rennes wrote:
> * gnu/packages/patches/wxwidgets-fix-windowGTK.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.

I'm unable to apply this patch to the Guix source tree. Please try
recreating it from current master and sending it again.

> diff --git a/gnu/packages/patches/wxwidgets-fix-windowGTK.patch b/gnu/packages/patches/wxwidgets-fix-windowGTK.patch
> new file mode 100644
> index 000000000..05e2e5819
> --- /dev/null
> +++ b/gnu/packages/patches/wxwidgets-fix-windowGTK.patch
> @@ -0,0 +1,35 @@
> +This patch allow Filezilla client to resize window.
> +
> +Authors: Tim Kosse <tim.kosse@filezilla-project.org>
> +Upstream status: This issue was fixed in master branch.
> +Ticket: '<http://trac.wxwidgets.org/ticket/17456>'
> +
> +From 3a52125f81d28fcad5d3c841b94a3e4bad295d9e Mon Sep 17 00:00:00 2001
> +From: Tim Kosse <tim.kosse@filezilla-project.org>
> +Date: Sun, 20 Mar 2016 10:22:13 +0100
> +Subject: [PATCH] Fix wxTopLevelWindowGTK::DoSetSizeHints if a window scale
> +factor larger than 1  is set.
> +
> +In this case, passing INT_MAX as maximum width/height hint
> +to gtk_window_set_geometry_hints leads to integer overlows.
> +
> +Instead, use INT_MAX / 16 which should work with all
> +resonable scale factors.

Okay, thanks!

But, instead of using the proposed patch from the upstream bug report,
we should use the commit that was applied to the appropriate wxWidgets
branch and, if possible, include a link to that commit in their
web-based Git interface.

Can you send an updated patch?