Re: Icecat crash

[Julien Lepiller <julien@lepiller.eu>]

[-- Attachment #1.1: Type: text/plain, Size: 1922 bytes --]

On Sun, 25 Dec 2016 21:15:19 -0500
Leo Famulari <leo@famulari.name> wrote:

> On Sun, Dec 25, 2016 at 05:47:33PM -0800, Chris Marusich wrote:
> > Danny Milosavljevic <dannym@scratchpost.org> writes:  
> > > so I've finally found a 100% reproducible way to crash icecat.
> > > Previously it has been sporadic and not reproducible.
> > >
> > > Try going to this site in a new icecat (guix master) instance:
> > >
> > > http://arstechnica.com/security/2016/12/this-low-cost-device-may-be-the-worlds-best-hope-against-account-takeovers/
> > >
> > > Scroll down. It will crash. Every time.  
> > 
> > This doesn't crash for me.  Note that I have applied the "fix" for
> > the previously observed "crashiness", as described here - perhaps
> > that is why it doesn't crash for me:
> > 
> > https://lists.gnu.org/archive/html/help-guix/2016-11/msg00008.html  
> 
> Unfortunately for debugging purposes, this doesn't crash Icecat for me
> either. I'm still using the Cairo rendering backend.
> 
> It's difficult to use a site like this as a reproducer, since every
> user will get totally different content via the advertisements.
> 
> For the record, it also does not crash my Debian Firefox 45.5.1, which
> uses uBlock Origin and Privacy Badger to block 1 and 9 domains,
> respectively.
> 
> If you can still reproduce the crash, I think it's worth it to save
> the entire web page, ads included, and share that if you're satisfied
> there's no sensitive data included.

Hey, I'm also experiencing crashes with icecat since a few months. It
just seems to happen randomly. I've found a note about that on the LFS
website on the firefox page that says that using system cairo is
causing a crash when it tries to do background rendering. So I've
changed our icecat recipe to use the bundled version of cairo, and I
don't get any crash anymore. Would something like this patch be
acceptable?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-icecat-Fix-random-crashes.patch --]
[-- Type: text/x-patch, Size: 2002 bytes --]

From 89a121bab987caef7f0fbe0f5e24085c3ccae42d Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Tue, 14 Feb 2017 20:59:15 +0100
Subject: [PATCH] gnu: icecat: Fix random crashes.

gnu/packages/gnuzilla.scm (icecat): Remove cairo dependency to fix crashes.
---
 gnu/packages/gnuzilla.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 9279c46b5..90655fd76 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -404,6 +404,8 @@ standards.")
                       ;; <https://bugzilla.mozilla.org/show_bug.cgi?id=847568>
                       ;;
                       ;; TODO: Use system graphite2.
+                      ;; TODO: Use system cairo. This currently causes random
+                      ;; crash when icecat does background rendering.
                       ;;
                       "modules/freetype2"
                       "modules/zlib"
@@ -412,7 +414,6 @@ standards.")
                       "media/libjpeg"
                       "media/libvpx"
                       "security/nss"
-                      "gfx/cairo"
                       "js/src/ctypes/libffi"
                       "db/sqlite3"))
           ;; Delete .pyc files, typically present in icecat source tarballs
@@ -426,7 +427,6 @@ standards.")
     (inputs
      `(("alsa-lib" ,alsa-lib)
        ("bzip2" ,bzip2)
-       ("cairo" ,cairo)
        ("cups" ,cups)
        ("dbus-glib" ,dbus-glib)
        ("gdk-pixbuf" ,gdk-pixbuf)
@@ -511,7 +511,6 @@ standards.")
                            "--with-system-nspr"
                            "--with-system-nss"
                            "--enable-system-pixman"
-                           "--enable-system-cairo"
                            "--enable-system-ffi"
                            "--enable-system-hunspell"
                            "--enable-system-sqlite"
-- 
2.11.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]