* Broken tests
@ 2017-02-11 17:15 David Craven
2017-02-13 8:44 ` Federico Beffa
2017-02-13 8:47 ` John Darrington
0 siblings, 2 replies; 5+ messages in thread
From: David Craven @ 2017-02-11 17:15 UTC (permalink / raw)
To: guix-devel, beffa
Hi!
> Revert "import: json: Explicitly ask for JSON data."
> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
I reverted this commit in my local repository for now, it breaks the
pypi, crate and some other test I can't recall (gem and/or cpan).
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Broken tests
2017-02-11 17:15 Broken tests David Craven
@ 2017-02-13 8:44 ` Federico Beffa
2017-02-13 15:08 ` Ludovic Courtès
2017-02-13 8:47 ` John Darrington
1 sibling, 1 reply; 5+ messages in thread
From: Federico Beffa @ 2017-02-13 8:44 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel
On Sat, Feb 11, 2017 at 6:15 PM, David Craven <david@craven.ch> wrote:
> Hi!
>
>> Revert "import: json: Explicitly ask for JSON data."
>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
>
> I reverted this commit in my local repository for now, it breaks the
> pypi, crate and some other test I can't recall (gem and/or cpan).
The importers seems to be working as before. I believe that the
problem is with the tests. They replace the function 'http-fetch', but
do not replicate the signature of the original function and instead
use a different one.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Broken tests
2017-02-11 17:15 Broken tests David Craven
2017-02-13 8:44 ` Federico Beffa
@ 2017-02-13 8:47 ` John Darrington
1 sibling, 0 replies; 5+ messages in thread
From: John Darrington @ 2017-02-13 8:47 UTC (permalink / raw)
To: David Craven; +Cc: guix-devel, beffa
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Sat, Feb 11, 2017 at 06:15:08PM +0100, David Craven wrote:
Hi!
> Revert "import: json: Explicitly ask for JSON data."
> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
I reverted this commit in my local repository for now, it breaks the
pypi, crate and some other test I can't recall (gem and/or cpan).
David
Yes, I noticed the same problem and similarly had to revert locally.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Broken tests
2017-02-13 8:44 ` Federico Beffa
@ 2017-02-13 15:08 ` Ludovic Courtès
2017-02-13 18:42 ` Leo Famulari
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-02-13 15:08 UTC (permalink / raw)
To: Federico Beffa; +Cc: guix-devel
Hello,
Federico Beffa <beffa@ieee.org> skribis:
> On Sat, Feb 11, 2017 at 6:15 PM, David Craven <david@craven.ch> wrote:
>> Hi!
>>
>>> Revert "import: json: Explicitly ask for JSON data."
>>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
>>
>> I reverted this commit in my local repository for now, it breaks the
>> pypi, crate and some other test I can't recall (gem and/or cpan).
>
> The importers seems to be working as before. I believe that the
> problem is with the tests. They replace the function 'http-fetch', but
> do not replicate the signature of the original function and instead
> use a different one.
Indeed. Fixed in ce8963c5b7a728257920aeceeb89e40d166d09f4.
Please make sure to run the test suite before changing non-package code.
In general, I think we can agree on reverting changes that break the
tests until a solution is proposed (and once the original author has
been notified, of course). That sounds like reasonable policy to me.
Thoughts?
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Broken tests
2017-02-13 15:08 ` Ludovic Courtès
@ 2017-02-13 18:42 ` Leo Famulari
0 siblings, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2017-02-13 18:42 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel, Federico Beffa
On Mon, Feb 13, 2017 at 04:08:00PM +0100, Ludovic Courtès wrote:
> In general, I think we can agree on reverting changes that break the
> tests until a solution is proposed (and once the original author has
> been notified, of course). That sounds like reasonable policy to me.
>
> Thoughts?
I agree.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-13 18:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-11 17:15 Broken tests David Craven
2017-02-13 8:44 ` Federico Beffa
2017-02-13 15:08 ` Ludovic Courtès
2017-02-13 18:42 ` Leo Famulari
2017-02-13 8:47 ` John Darrington
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).