From mboxrd@z Thu Jan  1 00:00:00 1970
From: ng0 <contact.ng0@cryptolab.net>
Subject: Re: [PATCH 6/9] gnu: Add python-pytest-httpbin-0.0.7.
Date: Wed, 8 Feb 2017 12:49:30 +0000
Message-ID: <20170208124930.bh4k2ow365vj3e5r@wasp>
References: <20170204163506.16758-1-contact.ng0@cryptolab.net>
	<20170204163506.16758-7-contact.ng0@cryptolab.net>
	<8737fs8bpv.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1cbRfC-0001cY-Q8
	for guix-devel@gnu.org; Wed, 08 Feb 2017 07:48:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1cbRf9-0002Hk-Mf
	for guix-devel@gnu.org; Wed, 08 Feb 2017 07:47:58 -0500
Received: from latitanza.investici.org ([82.94.249.234]:27276)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <contact.ng0@cryptolab.net>)
	id 1cbRf9-0002Gn-CW
	for guix-devel@gnu.org; Wed, 08 Feb 2017 07:47:55 -0500
Content-Disposition: inline
In-Reply-To: <8737fs8bpv.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: guix-devel@gnu.org

On 17-02-05 15:22:20, Maxim Cournoyer wrote:
> contact.ng0@cryptolab.net writes:
> 
> > From: ng0 <ng0@libertad.pw>
> >
> > * gnu/packages/python.scm (python-pytest-httpbin-0.0.7): New variable.
> > ---
> >  gnu/packages/python.scm | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index 9c3a031e1..7bdd371b5 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -1975,6 +1975,29 @@ thread running httpbin and provides your test with the URL in the fixture.")
> >  (define-public python2-pytest-httpbin
> >    (package-with-python2 python-pytest-httpbin))
> >  
> > +;; Some packages like "searx" need this old version.
> > +(define-public python-pytest-httpbin-0.0.7
> > +  (package
> > +    (inherit python-pytest-httpbin)
> > +    (version "0.0.7")
> > +    (source
> > +     (origin
> > +       (method url-fetch)
> > +       (uri (pypi-uri "pytest-httpbin" version))
> > +       (sha256
> > +        (base32
> > +         "08ghq923dn33rllip3vap2p9fb680g0i96jdn5lcpfy8amq8mbq3"))))))
> > +
> > +(define-public python2-pytest-httpbin-0.0.7
> > +  (package
> > +    (inherit (package-with-python2
> > +              (strip-python2-variant python-pytest-httpbin-0.0.7)))
> > +    (inputs
> > +     `(("python2-flask" ,python2-flask)
> > +       ("python2-decorator" ,python2-decorator)
> > +       ("python2-httpbin" ,python2-httpbin)
> > +       ("python2-six" ,python2-six)))))
> > +
> 
> Again, shouldn't those be propagated-inputs? Unless I missed something
> this was the recommendation going forward for Python runtime dependencies.
> 
> >  (define-public python-scripttest
> >    (package
> >      (name "python-scripttest")

Definitely. These patches predate the proposed changes and I didn't
check all of them.

I don't have the time to apply changes this work week. I'll see to apply
changes on sunday or monday.

Any reviews etc in the next days are considered with the next patch
submission.

Thanks!
-- 
ng0 -- https://www.inventati.org/patternsinthechaos/