From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH v2] gnu: new re2c package, version 0.16 Date: Sun, 5 Feb 2017 12:08:57 +0000 Message-ID: <20170205120857.3lbqz62jwx4slivl@wasp> References: <20170205004730.h6b6wy45fesxzqlz@wasp> <20170205103447.27375-1-slyfox@inbox.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caLbb-0005x6-Ay for guix-devel@gnu.org; Sun, 05 Feb 2017 07:07:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caLbX-0004lK-AB for guix-devel@gnu.org; Sun, 05 Feb 2017 07:07:43 -0500 Received: from perdizione.investici.org ([94.23.50.208]:46516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caLbW-0004kg-TI for guix-devel@gnu.org; Sun, 05 Feb 2017 07:07:39 -0500 Content-Disposition: inline In-Reply-To: <20170205103447.27375-1-slyfox@inbox.ru> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sergei Trofimovich Cc: guix-devel@gnu.org Hi, I've applied and build this, and I have other remarks: The commit message should look like this: gnu: Add re2c. * gnu/packages/re2c.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Add re2c.scm. The "tested on(...)" is more of a personal note and not needed in the commit message. I get no difference to the re2c package I have (identical build) so when those changes will be applied it's good to go from my side. On 17-02-05 10:34:47, Sergei Trofimovich wrote: > Tested on x86_64-linux and i686-linux. >=20 > * gnu/local.mk: add re2c.scm to dist > * gnu/packages/re2c.scm: new file >=20 > CC: ng0 > Signed-off-by: Sergei Trofimovich > --- > Change since v1: texinfo-ified descriotion as suggested by ng0 >=20 > gnu/local.mk | 1 + > gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++= ++++ > 2 files changed, 48 insertions(+) > create mode 100644 gnu/packages/re2c.scm >=20 > diff --git a/gnu/local.mk b/gnu/local.mk > index 0948321c9..5c1634e02 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =3D \ > %D%/packages/ratpoison.scm \ > %D%/packages/rdesktop.scm \ > %D%/packages/rdf.scm \ > + %D%/packages/re2c.scm \ > %D%/packages/readline.scm \ > %D%/packages/regex.scm \ > %D%/packages/rrdtool.scm \ > diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm > new file mode 100644 > index 000000000..c7f296638 > --- /dev/null > +++ b/gnu/packages/re2c.scm > @@ -0,0 +1,47 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2017 Sergei Trofimovich > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify i= t > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or = (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages re2c) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu)) > + > +(define-public re2c > + (package > + (name "re2c") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/skvadrik/" name > + "/releases/download/" version "/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8")= ))) > + (build-system gnu-build-system) > + (home-page "http://re2c.org/") > + (synopsis "Lexer generator for C/C++") > + (description > + "@code{re2c} generates minimalistic hard-coded state machine (as = opposed > +to full-featured table-based lexers). Flexible API allows generated c= ode > +to be wired into virtually any environment. Instead of exposing tradi= tional > +@code{yylex()} style API, re2c exposes its internals. Be sure to take= a look > +at examples, they cover a lot of real-world cases and shed some light = on dark > +corners of re2c API.") > + (license public-domain))) > --=20 > 2.11.1 >=20 --=20 ng0 -- https://www.inventati.org/patternsinthechaos/