From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: new re2c package, version 0.16 Date: Sun, 5 Feb 2017 00:47:30 +0000 Message-ID: <20170205004730.h6b6wy45fesxzqlz@wasp> References: <20170204174323.25083-1-slyfox@inbox.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caAxy-0007Oj-1u for guix-devel@gnu.org; Sat, 04 Feb 2017 19:46:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caAxu-0004TC-4o for guix-devel@gnu.org; Sat, 04 Feb 2017 19:46:06 -0500 Received: from latitanza.investici.org ([2001:888:2000:56::19]:34150) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caAxt-0004Sz-Ng for guix-devel@gnu.org; Sat, 04 Feb 2017 19:46:02 -0500 Content-Disposition: inline In-Reply-To: <20170204174323.25083-1-slyfox@inbox.ru> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sergei Trofimovich Cc: guix-devel@gnu.org On 17-02-04 17:43:23, Sergei Trofimovich wrote: > Tested on x86_64-linux and i686-linux. >=20 > * gnu/local.mk: add re2c.scm to dist > * gnu/packages/re2c.scm: new file Cool! I had the same package somewhere, thanks for publishing yours :) I think there's already a module this could go into. If there isn't (I will check tomorrow), what about a more generic name which could hold a class of applications? Just an idea. I haven't run the code, these are just my initial remarks. Overall it looks good, so the only criticism is really in the (description). =20 > Signed-off-by: Sergei Trofimovich > --- > gnu/local.mk | 1 + > gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++= ++++ > 2 files changed, 48 insertions(+) > create mode 100644 gnu/packages/re2c.scm >=20 > diff --git a/gnu/local.mk b/gnu/local.mk > index 0948321c9..5c1634e02 100644 > --- a/gnu/local.mk > +++ b/gnu/local.mk > @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =3D \ > %D%/packages/ratpoison.scm \ > %D%/packages/rdesktop.scm \ > %D%/packages/rdf.scm \ > + %D%/packages/re2c.scm \ > %D%/packages/readline.scm \ > %D%/packages/regex.scm \ > %D%/packages/rrdtool.scm \ > diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm > new file mode 100644 > index 000000000..7c5698a82 > --- /dev/null > +++ b/gnu/packages/re2c.scm > @@ -0,0 +1,47 @@ > +;;; GNU Guix --- Functional package management for GNU > +;;; Copyright =C2=A9 2017 Sergei Trofimovich > +;;; > +;;; This file is part of GNU Guix. > +;;; > +;;; GNU Guix is free software; you can redistribute it and/or modify i= t > +;;; under the terms of the GNU General Public License as published by > +;;; the Free Software Foundation; either version 3 of the License, or = (at > +;;; your option) any later version. > +;;; > +;;; GNU Guix is distributed in the hope that it will be useful, but > +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +;;; GNU General Public License for more details. > +;;; > +;;; You should have received a copy of the GNU General Public License > +;;; along with GNU Guix. If not, see . > + > +(define-module (gnu packages re2c) > + #:use-module (guix licenses) > + #:use-module (guix packages) > + #:use-module (guix download) > + #:use-module (guix build-system gnu)) > + > +(define-public re2c > + (package > + (name "re2c") > + (version "0.16") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/skvadrik/" name > + "/releases/download/" version "/" > + name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8")= ))) > + (build-system gnu-build-system) > + (home-page "http://re2c.org/") > + (synopsis "Lexer generator for C/C++") > + (description > + "re2c generates minimalistic hard-coded state machine (as opposed= to I think the beginning should be "Re2c (...)" or "@code{re2c} (...)" > +full-featured table-based lexers). Flexible API allows generated code= to > +be wired into virtually any environment. Instead of exposing traditio= nal > +yylex() style API, re2c exposes its internals. Be sure to take a look= at I'm not sure, but I think the "yylex()" will have to be written as @code{yylex()} or something similar. > +examples, they cover a lot of real-world cases and shed some light on = dark > +corners of re2c API.") I think "corners of the re2c API." would be correct? > + (license public-domain))) > --=20 > 2.11.1 >=20 >=20 --=20 ng0 -- https://www.inventati.org/patternsinthechaos/