Re: [PATCH] gnu: new re2c package, version 0.16

[ng0 <contact.ng0@cryptolab.net>]

On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> Tested on x86_64-linux and i686-linux.
> 
> * gnu/local.mk: add re2c.scm to dist
> * gnu/packages/re2c.scm: new file

Cool! I had the same package somewhere, thanks for publishing yours :)
I think there's already a module this could go into. If there isn't (I
will check tomorrow), what about a more generic name which could hold a
class of applications? Just an idea.

I haven't run the code, these are just my initial remarks. Overall it
looks good, so the only criticism is really in the (description).
 
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
> ---
>  gnu/local.mk          |  1 +
>  gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 gnu/packages/re2c.scm
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 0948321c9..5c1634e02 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ratpoison.scm			\
>    %D%/packages/rdesktop.scm			\
>    %D%/packages/rdf.scm				\
> +  %D%/packages/re2c.scm				\
>    %D%/packages/readline.scm			\
>    %D%/packages/regex.scm				\
>    %D%/packages/rrdtool.scm			\
> diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
> new file mode 100644
> index 000000000..7c5698a82
> --- /dev/null
> +++ b/gnu/packages/re2c.scm
> @@ -0,0 +1,47 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages re2c)
> +  #:use-module (guix licenses)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public re2c
> +  (package
> +    (name "re2c")
> +    (version "0.16")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/skvadrik/" name
> +                                 "/releases/download/" version "/"
> +                                 name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://re2c.org/")
> +    (synopsis "Lexer generator for C/C++")
> +    (description
> +     "re2c generates minimalistic hard-coded state machine (as opposed to

I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"

> +full-featured table-based lexers).  Flexible API allows generated code to
> +be wired into virtually any environment.  Instead of exposing traditional
> +yylex() style API, re2c exposes its internals.  Be sure to take a look at

I'm not sure, but I think the "yylex()" will have to be written as
@code{yylex()} or something similar.

> +examples, they cover a lot of real-world cases and shed some light on dark
> +corners of re2c API.")

I think "corners of the re2c API." would be correct?

> +    (license public-domain)))
> -- 
> 2.11.1
> 
> 

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/