From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
Date: Sat, 4 Feb 2017 18:28:05 +0100
Message-ID: <20170204182805.099e8ba8@scratchpost.org>
References: <20170130030649.1716-1-huang_ying_caritas@163.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40819)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1ca48G-0002an-KW
	for guix-devel@gnu.org; Sat, 04 Feb 2017 12:28:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1ca48B-0002Tg-NM
	for guix-devel@gnu.org; Sat, 04 Feb 2017 12:28:16 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:41007)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1ca48B-0002T1-Go
	for guix-devel@gnu.org; Sat, 04 Feb 2017 12:28:11 -0500
In-Reply-To: <20170130030649.1716-1-huang_ying_caritas@163.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: huang_ying_caritas@163.com
Cc: guix-devel@gnu.org

Hi,

On Mon, 30 Jan 2017 11:06:49 +0800
huang_ying_caritas@163.com wrote:

> -(define* (manifest-lookup-package manifest name #:optional version)
> +(define* (manifest-lookup-package manifest name #:optional version output)
>    "Return as a monadic value the first package or store path referenced by
>  MANIFEST that is named NAME and optionally has the given VERSION prefix, or #f
>  if not found."

Please update the docstring too.

> +                     (if output
> +                         (string-suffix? output version*)
>                           #t))))

Should that include the separator between the parts? Otherwise it could maybe have false positives...