From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: [PATCH 1/1] gnu: libevent: Skip test that fails on 32bit. Date: Wed, 1 Feb 2017 20:28:28 +0100 Message-ID: <20170201192828.1252-1-mbakke@fastmail.com> Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZ0a6-0007cx-MG for guix-devel@gnu.org; Wed, 01 Feb 2017 14:28:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZ0a2-0000jx-NS for guix-devel@gnu.org; Wed, 01 Feb 2017 14:28:38 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:43497) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZ0a1-0000jh-CT for guix-devel@gnu.org; Wed, 01 Feb 2017 14:28:34 -0500 List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Cc: Marius Bakke * gnu/packages/patches/libevent-2.1-skip-failing-32bit-test.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/libevent.scm (libevent)[source]: Use it. --- gnu/local.mk | 1 + gnu/packages/libevent.scm | 5 ++++- .../libevent-2.1-skip-failing-32bit-test.patch | 22 ++++++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/libevent-2.1-skip-failing-32bit-test.patch diff --git a/gnu/local.mk b/gnu/local.mk index da4dbb0d2..cd2c034fc 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -676,6 +676,7 @@ dist_patch_DATA = \ %D%/packages/patches/libevent-2.0-evdns-fix-searching-empty-hostnames.patch \ %D%/packages/patches/libevent-2.0-evutil-fix-buffer-overflow.patch \ %D%/packages/patches/libevent-2.1-dns-tests.patch \ + %D%/packages/patches/libevent-2.1-skip-failing-32bit-test.patch \ %D%/packages/patches/libextractor-ffmpeg-3.patch \ %D%/packages/patches/libjxr-fix-function-signature.patch \ %D%/packages/patches/libjxr-fix-typos.patch \ diff --git a/gnu/packages/libevent.scm b/gnu/packages/libevent.scm index ca59db390..9b06ae3e1 100644 --- a/gnu/packages/libevent.scm +++ b/gnu/packages/libevent.scm @@ -43,7 +43,10 @@ (sha256 (base32 "1hhxnxlr0fsdv7bdmzsnhdz16fxf3jg2r6vyljcl3kj6pflcap4n")) - (patches (search-patches "libevent-2.1-dns-tests.patch")))) + (patches (search-patches "libevent-2.1-dns-tests.patch" + ;; XXX: Try removing this for > 2.1.8. + ;; https://github.com/libevent/libevent/issues/452 + "libevent-2.1-skip-failing-32bit-test.patch")))) (build-system gnu-build-system) (inputs `(("python" ,python-2))) ; for 'event_rpcgen.py' diff --git a/gnu/packages/patches/libevent-2.1-skip-failing-32bit-test.patch b/gnu/packages/patches/libevent-2.1-skip-failing-32bit-test.patch new file mode 100644 index 000000000..aba49ef50 --- /dev/null +++ b/gnu/packages/patches/libevent-2.1-skip-failing-32bit-test.patch @@ -0,0 +1,22 @@ +XXX: These fail on 32-bit due to an overflow bug in the test program. + +Upstream bug URL: + +https://github.com/libevent/libevent/issues/452 + +diff --git a/test/regress_util.c b/test/regress_util.c +index ef6a1487..4de501fc 100644 +--- a/test/regress_util.c ++++ b/test/regress_util.c +@@ -1413,9 +1413,9 @@ static struct date_rfc1123_case { + { 1323648000, "Mon, 12 Dec 2011 00:00:00 GMT"}, + #ifndef _WIN32 + /** In win32 case we have max "23:59:59 January 18, 2038, UTC" for time32 */ +- { 4294967296, "Sun, 07 Feb 2106 06:28:16 GMT"} /* 2^32 */, ++ //{ 4294967296, "Sun, 07 Feb 2106 06:28:16 GMT"} /* 2^32 */, + /** In win32 case we have max "23:59:59, December 31, 3000, UTC" for time64 */ +- {253402300799, "Fri, 31 Dec 9999 23:59:59 GMT"} /* long long future no one can imagine */, ++ //{253402300799, "Fri, 31 Dec 9999 23:59:59 GMT"} /* long long future no one can imagine */, + { 1456704000, "Mon, 29 Feb 2016 00:00:00 GMT"} /* leap year */, + #endif + { 1435708800, "Wed, 01 Jul 2015 00:00:00 GMT"} /* leap second */, -- 2.11.0