* [PATCH] gnu: magit: Update to 2.10.1.
@ 2017-02-01 14:14 Clément Lassieur
2017-02-01 22:52 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Clément Lassieur @ 2017-02-01 14:14 UTC (permalink / raw)
To: guix-devel
* gnu/packages/emacs.scm (magit): Update to 2.10.1.
---
gnu/packages/emacs.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index df7f7869d..aac464778 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -19,6 +19,7 @@
;;; Copyright © 2016 Arun Isaac <arunisaac@systemreboot.net>
;;; Copyright © 2017 Christopher Baines <mail@cbaines.net>
;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com>
+;;; Copyright © 2017 Clément Lassieur <clement@lassieur.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -426,7 +427,7 @@ on stdout instead of using a socket as the Emacsclient does.")
(define-public magit
(package
(name "magit")
- (version "2.10.0")
+ (version "2.10.1")
(source (origin
(method url-fetch)
(uri (string-append
@@ -434,7 +435,7 @@ on stdout instead of using a socket as the Emacsclient does.")
version "/" name "-" version ".tar.gz"))
(sha256
(base32
- "1w74vy46z922kfs7gjkrng7wjpi481calpasqmjzpn3hqvgsd5d1"))))
+ "1a3gsarl0zrk1dydqn93kx7pnwm7pb7av7g17pj5m7b7kc66k7jv"))))
(build-system gnu-build-system)
(native-inputs `(("texinfo" ,texinfo)
("emacs" ,emacs-minimal)))
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: magit: Update to 2.10.1.
2017-02-01 14:14 [PATCH] gnu: magit: Update to 2.10.1 Clément Lassieur
@ 2017-02-01 22:52 ` Ludovic Courtès
2017-02-02 9:09 ` Alex Kost
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-02-01 22:52 UTC (permalink / raw)
To: Clément Lassieur; +Cc: guix-devel
Clément Lassieur <clement@lassieur.org> skribis:
> * gnu/packages/emacs.scm (magit): Update to 2.10.1.
Applied, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: magit: Update to 2.10.1.
2017-02-01 22:52 ` Ludovic Courtès
@ 2017-02-02 9:09 ` Alex Kost
2017-02-03 16:45 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Alex Kost @ 2017-02-02 9:09 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel, Clément Lassieur
Ludovic Courtès (2017-02-01 23:52 +0100) wrote:
> Clément Lassieur <clement@lassieur.org> skribis:
>
>> * gnu/packages/emacs.scm (magit): Update to 2.10.1.
>
> Applied, thanks!
No, no, arrgh! I didn't update magit to 2.10.1 because it has a bug
that makes "C" key in COMMIT_EDITMSG buffer unusable, as discussed at
<https://github.com/magit/magit/issues/2981>.
Also note that along with magit, 'emacs-magit-popup' should be updated
(this time it wasn't needed as "magit-popup.el" wasn't touched in this
release), and it is also good to update 'emacs-with-editor' as this
library was written specifically for magit (it was a part of magit in
the past).
--
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: magit: Update to 2.10.1.
2017-02-02 9:09 ` Alex Kost
@ 2017-02-03 16:45 ` Ludovic Courtès
2017-02-03 20:04 ` Alex Kost
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-02-03 16:45 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel, Clément Lassieur
Alex Kost <alezost@gmail.com> skribis:
> Ludovic Courtès (2017-02-01 23:52 +0100) wrote:
>
>> Clément Lassieur <clement@lassieur.org> skribis:
>>
>>> * gnu/packages/emacs.scm (magit): Update to 2.10.1.
>>
>> Applied, thanks!
>
> No, no, arrgh! I didn't update magit to 2.10.1 because it has a bug
> that makes "C" key in COMMIT_EDITMSG buffer unusable, as discussed at
> <https://github.com/magit/magit/issues/2981>.
>
> Also note that along with magit, 'emacs-magit-popup' should be updated
> (this time it wasn't needed as "magit-popup.el" wasn't touched in this
> release), and it is also good to update 'emacs-with-editor' as this
> library was written specifically for magit (it was a part of magit in
> the past).
Oops, I’m doubly sorry. Please revert the upgrade then!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gnu: magit: Update to 2.10.1.
2017-02-03 16:45 ` Ludovic Courtès
@ 2017-02-03 20:04 ` Alex Kost
0 siblings, 0 replies; 5+ messages in thread
From: Alex Kost @ 2017-02-03 20:04 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: guix-devel, Clément Lassieur
Ludovic Courtès (2017-02-03 17:45 +0100) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Courtès (2017-02-01 23:52 +0100) wrote:
>>
>>> Clément Lassieur <clement@lassieur.org> skribis:
>>>
>>>> * gnu/packages/emacs.scm (magit): Update to 2.10.1.
>>>
>>> Applied, thanks!
>>
>> No, no, arrgh! I didn't update magit to 2.10.1 because it has a bug
>> that makes "C" key in COMMIT_EDITMSG buffer unusable, as discussed at
>> <https://github.com/magit/magit/issues/2981>.
>>
>> Also note that along with magit, 'emacs-magit-popup' should be updated
>> (this time it wasn't needed as "magit-popup.el" wasn't touched in this
>> release), and it is also good to update 'emacs-with-editor' as this
>> library was written specifically for magit (it was a part of magit in
>> the past).
>
> Oops, I’m doubly sorry. Please revert the upgrade then!
Hm, I'm not sure, is it really needed? I mean it's not a big bug, magit
works after all, besides "C" key sometimes also works as expected, it is
broken only in some cases.
Thanks to Guix, we can easily roll back to a previous version, so I
would leave it as it is, but, well, I don't know :-)
--
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-03 20:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-01 14:14 [PATCH] gnu: magit: Update to 2.10.1 Clément Lassieur
2017-02-01 22:52 ` Ludovic Courtès
2017-02-02 9:09 ` Alex Kost
2017-02-03 16:45 ` Ludovic Courtès
2017-02-03 20:04 ` Alex Kost
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).