Add configure-flags to tor.

Add configure-flags to tor.

[contact.ng0]

This adds tor hardening flags.  Do you want me to document the flags in the package? I left it out since it's documented in the tor release itself.

Taken from ReleaseNotes:

'--enable-expensive-hardening'

   New --enable-expensive-hardening option to enable security
   hardening options that consume nontrivial amounts of CPU and
   memory. Right now, this includes AddressSanitizer and UbSan, which
   are supported in newer versions of GCC and Clang. Closes ticket
   11477.

'--enable-gcc-hardening'

  New "--enable-gcc-hardening" ./configure flag (off by default)
  to turn on gcc compile time hardening options. It ensures
  that signed ints have defined behavior (-fwrapv), enables
  -D_FORTIFY_SOURCE=2 (requiring -O2), adds stack smashing protection
  with canaries (-fstack-protector-all), turns on ASLR protection if
  supported by the kernel (-fPIE, -pie), and adds additional security
  related warnings. Verified to work on Mac OS X and Debian Lenny.

'--enable-linker-hardening'

  New "--enable-linker-hardening" ./configure flag (off by default)
  to turn on ELF specific hardening features (relro, now). This does
  not work with Mac OS X or any other non-ELF binary format.

[PATCH] gnu: tor: Add hardening configure-flags.

[contact.ng0]

From: ng0 <contact.ng0@cryptolab.net>

* gnu/packages/tor.scm (tor)[arguments]: Add '--enable-expensive-hardening',
'enable-gcc-hardening', '--enable-linker-hardening' to configure-flags.
---
 gnu/packages/tor.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
index c7f97ab1b..ae8e59b70 100644
--- a/gnu/packages/tor.scm
+++ b/gnu/packages/tor.scm
@@ -48,6 +48,10 @@
               (base32
                "0hqdk5p6dw4bpn7c8gmhyi8jjkhc37112pfw5nx4gl0g4lmmscik"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags (list "--enable-expensive-hardening"
+                               "--enable-gcc-hardening"
+                               "--enable-linker-hardening")))
     (native-inputs
      `(("python" ,python-2)))  ; for tests
     (inputs
-- 
2.11.0

Re: [PATCH] gnu: tor: Add hardening configure-flags.

[Leo Famulari]

On Wed, Jan 25, 2017 at 09:31:07AM +0000, contact.ng0@cryptolab.net wrote:
> From: ng0 <contact.ng0@cryptolab.net>
> 
> * gnu/packages/tor.scm (tor)[arguments]: Add '--enable-expensive-hardening',
> 'enable-gcc-hardening', '--enable-linker-hardening' to configure-flags.

LGTM. Does anyone else want to test before pushing?

Re: [PATCH] gnu: tor: Add hardening configure-flags.

[Ludovic Courtès]

contact.ng0@cryptolab.net skribis:

> From: ng0 <contact.ng0@cryptolab.net>
>
> * gnu/packages/tor.scm (tor)[arguments]: Add '--enable-expensive-hardening',
> 'enable-gcc-hardening', '--enable-linker-hardening' to configure-flags.

Applied, thanks.

Ludo'.