* [PATCH 0/2] Tremc and transmission-remote-cli
@ 2017-01-27 7:10 Leo Famulari
2017-01-27 7:10 ` [PATCH 1/2] gnu: Add tremc Leo Famulari
2017-01-27 7:10 ` [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc Leo Famulari
0 siblings, 2 replies; 6+ messages in thread
From: Leo Famulari @ 2017-01-27 7:10 UTC (permalink / raw)
To: guix-devel
transmission-remote-cli is no longer maintained:
https://github.com/fagga/transmission-remote-cli/commit/edbeb35632ff8e93f7bf7959211fb1818f09f27a
But, there is a fork with a few bug fixes, tremc:
https://github.com/louipc/tremc
These patches add tremc and mark transmission-remote-cli as superseded
by tremc.
Leo Famulari (2):
gnu: Add tremc.
gnu: transmission-remote-cli: Superseded by tremc.
gnu/packages/bittorrent.scm | 51 +++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 49 insertions(+), 2 deletions(-)
--
2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] gnu: Add tremc.
2017-01-27 7:10 [PATCH 0/2] Tremc and transmission-remote-cli Leo Famulari
@ 2017-01-27 7:10 ` Leo Famulari
2017-01-27 18:31 ` Marius Bakke
2017-01-27 7:10 ` [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc Leo Famulari
1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-01-27 7:10 UTC (permalink / raw)
To: guix-devel
* gnu/packages/bittorrent.scm (tremc): New variable.
---
gnu/packages/bittorrent.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index 716d8b766..a7294f38a 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -2,6 +2,7 @@
;;; Copyright © 2014 Taylan Ulrich Bayirli/Kammer <taylanbayirli@gmail.com>
;;; Copyright © 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
+;;; Copyright © 2016, 2017 Leo Famulari <leo@famulari.name>
;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
;;; Copyright © 2016 Tomáš Čech <sleep_walker@gnu.org>
;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
@@ -25,6 +26,7 @@
(define-module (gnu packages bittorrent)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix build-system gnu)
#:use-module (guix build-system python)
#:use-module (guix build-system glib-or-gtk)
@@ -172,6 +174,49 @@ XML-RPC over SCGI.")
(home-page "https://github.com/rakshasa/rtorrent")
(license l:gpl2+)))
+(define-public tremc
+ (let ((commit "401f2303c9b5a6e2e7b0808617d794576d4aa29e")
+ (revision "0"))
+ (package
+ (name "tremc")
+ (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/louipc/tremc.git")
+ (commit commit)))
+ (sha256
+ (base32
+ "1h2720zn35iggmf9av65g119b0bhskwm1ng0zbkjryaf38nfzpin"))))
+ (build-system python-build-system)
+ (arguments
+ `(#:tests? #f ; no test suite
+ #:phases
+ (modify-phases %standard-phases
+ ;; The software is just a Python script that must be
+ ;; copied into place.
+ (delete 'build)
+ (replace 'install
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin"))
+ (man (string-append out "/share/man/man1"))
+ ;; FIXME install zsh completions
+ (completions (string-append out "/etc/bash_completion.d")))
+ (install-file "tremc" bin)
+ (install-file "tremc.1" man)
+ (install-file
+ (string-append
+ "completion/bash/"
+ "transmission-remote-cli-bash-completion.sh")
+ completions)))))))
+ (synopsis "Console client for the Transmission BitTorrent daemon")
+ (description "Tremc is a console client, with a curses interface, for the
+Transmission BitTorrent daemon.")
+ (home-page "https://github.com/louipc/tremc")
+ (license l:gpl3+))))
+
(define-public transmission-remote-cli
(package
(name "transmission-remote-cli")
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc.
2017-01-27 7:10 [PATCH 0/2] Tremc and transmission-remote-cli Leo Famulari
2017-01-27 7:10 ` [PATCH 1/2] gnu: Add tremc Leo Famulari
@ 2017-01-27 7:10 ` Leo Famulari
2017-01-27 18:32 ` Marius Bakke
1 sibling, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-01-27 7:10 UTC (permalink / raw)
To: guix-devel
* gnu/packages/bittorrent.scm (transmission-remote-cli)[properties]: New field.
---
gnu/packages/bittorrent.scm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
index a7294f38a..facc2be53 100644
--- a/gnu/packages/bittorrent.scm
+++ b/gnu/packages/bittorrent.scm
@@ -254,9 +254,11 @@ Transmission BitTorrent daemon.")
completions)))))))
(synopsis "Console client for the Transmission BitTorrent daemon")
(description "Transmission-remote-cli is a console client, with a curses
-interface, for the Transmission BitTorrent daemon.")
+interface, for the Transmission BitTorrent daemon. This package is no longer
+maintained upstream.")
(home-page "https://github.com/fagga/transmission-remote-cli")
- (license l:gpl3+)))
+ (license l:gpl3+)
+ (properties `((superseded . ,tremc)))))
(define-public aria2
(package
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] gnu: Add tremc.
2017-01-27 7:10 ` [PATCH 1/2] gnu: Add tremc Leo Famulari
@ 2017-01-27 18:31 ` Marius Bakke
2017-01-28 8:32 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2017-01-27 18:31 UTC (permalink / raw)
To: Leo Famulari, guix-devel
[-- Attachment #1: Type: text/plain, Size: 3664 bytes --]
Leo Famulari <leo@famulari.name> writes:
> * gnu/packages/bittorrent.scm (tremc): New variable.
> ---
> gnu/packages/bittorrent.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index 716d8b766..a7294f38a 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -2,6 +2,7 @@
> ;;; Copyright © 2014 Taylan Ulrich Bayirli/Kammer <taylanbayirli@gmail.com>
> ;;; Copyright © 2014, 2015, 2016 Ludovic Courtès <ludo@gnu.org>
> ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
> +;;; Copyright © 2016, 2017 Leo Famulari <leo@famulari.name>
> ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2016 Tomáš Čech <sleep_walker@gnu.org>
> ;;; Copyright © 2016 Tobias Geerinckx-Rice <me@tobias.gr>
> @@ -25,6 +26,7 @@
> (define-module (gnu packages bittorrent)
> #:use-module (guix packages)
> #:use-module (guix download)
> + #:use-module (guix git-download)
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system python)
> #:use-module (guix build-system glib-or-gtk)
> @@ -172,6 +174,49 @@ XML-RPC over SCGI.")
> (home-page "https://github.com/rakshasa/rtorrent")
> (license l:gpl2+)))
>
> +(define-public tremc
> + (let ((commit "401f2303c9b5a6e2e7b0808617d794576d4aa29e")
> + (revision "0"))
> + (package
> + (name "tremc")
> + (version (string-append "0.0.0-" revision "." (string-take commit 7)))
The script has a VERSION variable specifying 0.9.0, so I think we should
use that. It would of course be better if they provided tagged releases..
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/louipc/tremc.git")
> + (commit commit)))
> + (sha256
> + (base32
> + "1h2720zn35iggmf9av65g119b0bhskwm1ng0zbkjryaf38nfzpin"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:tests? #f ; no test suite
> + #:phases
> + (modify-phases %standard-phases
> + ;; The software is just a Python script that must be
> + ;; copied into place.
> + (delete 'build)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (man (string-append out "/share/man/man1"))
> + ;; FIXME install zsh completions
> + (completions (string-append out "/etc/bash_completion.d")))
> + (install-file "tremc" bin)
> + (install-file "tremc.1" man)
> + (install-file
> + (string-append
> + "completion/bash/"
> + "transmission-remote-cli-bash-completion.sh")
> + completions)))))))
> + (synopsis "Console client for the Transmission BitTorrent daemon")
> + (description "Tremc is a console client, with a curses interface, for the
> +Transmission BitTorrent daemon.")
So all the imports in the script are part of the python standard
library, including "curses"? Neat. LGTM!
> + (home-page "https://github.com/louipc/tremc")
> + (license l:gpl3+))))
> +
> (define-public transmission-remote-cli
> (package
> (name "transmission-remote-cli")
> --
> 2.11.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc.
2017-01-27 7:10 ` [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc Leo Famulari
@ 2017-01-27 18:32 ` Marius Bakke
0 siblings, 0 replies; 6+ messages in thread
From: Marius Bakke @ 2017-01-27 18:32 UTC (permalink / raw)
To: Leo Famulari, guix-devel
[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]
Leo Famulari <leo@famulari.name> writes:
> * gnu/packages/bittorrent.scm (transmission-remote-cli)[properties]: New field.
> ---
> gnu/packages/bittorrent.scm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm
> index a7294f38a..facc2be53 100644
> --- a/gnu/packages/bittorrent.scm
> +++ b/gnu/packages/bittorrent.scm
> @@ -254,9 +254,11 @@ Transmission BitTorrent daemon.")
> completions)))))))
> (synopsis "Console client for the Transmission BitTorrent daemon")
> (description "Transmission-remote-cli is a console client, with a curses
> -interface, for the Transmission BitTorrent daemon.")
> +interface, for the Transmission BitTorrent daemon. This package is no longer
> +maintained upstream.")
> (home-page "https://github.com/fagga/transmission-remote-cli")
> - (license l:gpl3+)))
> + (license l:gpl3+)
> + (properties `((superseded . ,tremc)))))
LGTM, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] gnu: Add tremc.
2017-01-27 18:31 ` Marius Bakke
@ 2017-01-28 8:32 ` Leo Famulari
0 siblings, 0 replies; 6+ messages in thread
From: Leo Famulari @ 2017-01-28 8:32 UTC (permalink / raw)
To: Marius Bakke; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Fri, Jan 27, 2017 at 07:31:31PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > * gnu/packages/bittorrent.scm (tremc): New variable.
> > + (version (string-append "0.0.0-" revision "." (string-take commit 7)))
>
> The script has a VERSION variable specifying 0.9.0, so I think we should
> use that. It would of course be better if they provided tagged releases..
Good catch!
> > + (description "Tremc is a console client, with a curses interface, for the
> > +Transmission BitTorrent daemon.")
>
> So all the imports in the script are part of the python standard
> library, including "curses"? Neat. LGTM!
Yes, that seems to be the case as its packaged. There are some optional
dependencies mentioned on the home-page, but I haven't packaged them.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-01-28 8:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-27 7:10 [PATCH 0/2] Tremc and transmission-remote-cli Leo Famulari
2017-01-27 7:10 ` [PATCH 1/2] gnu: Add tremc Leo Famulari
2017-01-27 18:31 ` Marius Bakke
2017-01-28 8:32 ` Leo Famulari
2017-01-27 7:10 ` [PATCH 2/2] gnu: transmission-remote-cli: Superseded by tremc Leo Famulari
2017-01-27 18:32 ` Marius Bakke
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).