* Re: 07/08: gnu: Add ocaml-ssl.
[not found] ` <20170116213517.59CD0220115@vcs.savannah.gnu.org>
@ 2017-01-23 21:31 ` Leo Famulari
2017-01-24 9:31 ` julien lepiller
0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2017-01-23 21:31 UTC (permalink / raw)
To: guix-devel
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On Mon, Jan 16, 2017 at 09:35:17PM +0000, julien lepiller wrote:
> roptat pushed a commit to branch master
> in repository guix.
>
> commit 37f17e2a1e797d3d1ea12da5afd69526e0abfd3e
> Author: Julien Lepiller <julien@lepiller.eu>
> Date: Fri Dec 30 11:53:24 2016 +0100
>
> gnu: Add ocaml-ssl.
>
> * gnu/packages/ocaml.scm (ocaml-ssl): New variable.
> + (substitute* "src/OCamlMakefile"
> + (("/bin/sh") (which "bash")))
> + (substitute* "configure"
> + (("/bin/sh") (which "bash"))))))))
Hi Julien!
I noticed that a handful of your new OCaml packages replace invocations
of 'sh' with 'bash'. These shells actually have different behavior even
though they are both provided by the Bash package (see INVOCATION in
bash(1)).
Can you change these substitutions to use (which "sh") instead?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 07/08: gnu: Add ocaml-ssl.
2017-01-23 21:31 ` 07/08: gnu: Add ocaml-ssl Leo Famulari
@ 2017-01-24 9:31 ` julien lepiller
2017-01-24 19:08 ` Leo Famulari
0 siblings, 1 reply; 3+ messages in thread
From: julien lepiller @ 2017-01-24 9:31 UTC (permalink / raw)
To: guix-devel
Le 2017-01-23 22:31, Leo Famulari a écrit :
> On Mon, Jan 16, 2017 at 09:35:17PM +0000, julien lepiller wrote:
>> roptat pushed a commit to branch master
>> in repository guix.
>>
>> commit 37f17e2a1e797d3d1ea12da5afd69526e0abfd3e
>> Author: Julien Lepiller <julien@lepiller.eu>
>> Date: Fri Dec 30 11:53:24 2016 +0100
>>
>> gnu: Add ocaml-ssl.
>>
>> * gnu/packages/ocaml.scm (ocaml-ssl): New variable.
>
>> + (substitute* "src/OCamlMakefile"
>> + (("/bin/sh") (which "bash")))
>> + (substitute* "configure"
>> + (("/bin/sh") (which "bash"))))))))
>
> Hi Julien!
>
> I noticed that a handful of your new OCaml packages replace invocations
> of 'sh' with 'bash'. These shells actually have different behavior even
> though they are both provided by the Bash package (see INVOCATION in
> bash(1)).
>
> Can you change these substitutions to use (which "sh") instead?
I didn't think it would cause any issue, but sure I will.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 07/08: gnu: Add ocaml-ssl.
2017-01-24 9:31 ` julien lepiller
@ 2017-01-24 19:08 ` Leo Famulari
0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2017-01-24 19:08 UTC (permalink / raw)
To: julien lepiller; +Cc: guix-devel
On Tue, Jan 24, 2017 at 10:31:49AM +0100, julien lepiller wrote:
> Le 2017-01-23 22:31, Leo Famulari a écrit :
> > Can you change these substitutions to use (which "sh") instead?
>
> I didn't think it would cause any issue, but sure I will.
Hopefully it doesn't cause an issue, but we should stick with the
upstream developers' choice of shell.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-24 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170116213516.17292.49031@vcs.savannah.gnu.org>
[not found] ` <20170116213517.59CD0220115@vcs.savannah.gnu.org>
2017-01-23 21:31 ` 07/08: gnu: Add ocaml-ssl Leo Famulari
2017-01-24 9:31 ` julien lepiller
2017-01-24 19:08 ` Leo Famulari
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).