From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= Subject: Re: [PATCH] gnu: add geos Date: Mon, 23 Jan 2017 00:12:51 +0100 Message-ID: <20170123001251.1e2d7bef@alma-ubu> References: <20170120183531.7ec19200@alma-ubu> <87vat85znn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVRJj-0007hr-PN for guix-devel@gnu.org; Sun, 22 Jan 2017 18:13:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVRJf-0005DN-8V for guix-devel@gnu.org; Sun, 22 Jan 2017 18:12:59 -0500 Received: from m4s11.vlinux.de ([83.151.27.109]:43403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVRJf-0005Cz-1D for guix-devel@gnu.org; Sun, 22 Jan 2017 18:12:55 -0500 Received: from alma-ubu (pD9EA5345.dip0.t-ipconnect.de [217.234.83.69]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by m4s11.vlinux.de (Postfix) with ESMTPSA id 2D29447BB for ; Sun, 22 Jan 2017 23:05:56 +0000 (UTC) In-Reply-To: <87vat85znn.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Thanks for accepting! I have some comments/questions below. Bj=C3=B6rn On Sat, 21 Jan 2017 14:08:12 +0100 Marius Bakke wrote: > Bj=C3=B6rn H=C3=B6fling writes: >=20 > > * gnu/packages/geo.scm (geos): New variable. =20 >=20 > Thanks for this! I've applied it with some minor changes, described > below: >=20 > > +(define-public geos > > + (package > > + (name "geos") > > + (version "3.6.1") > > + (source (origin > > + (method url-fetch) > > + (uri (string-append > > "http://download.osgeo.org/geos/geos-" > > + version > > + ".tar.bz2")) > > + (sha256 > > + (base32 > > + > > "1icz31kd5sml2kdxhjznvmv33zfr6nig9l0i6bdcz9q9g8x4wbja")))) > > + (build-system gnu-build-system) > > + (arguments `(#:phases > > + (modify-phases %standard-phases > > + (add-after > > + 'unpack 'patch-test-shebangs > > + (lambda _ > > + (substitute* > > '("tests/xmltester/testrunner.sh" > > + > > "tests/geostest/testrunner.sh") > > + (("/bin/sh") (which "bash"))) =20 >=20 > Bash behaves differently based on whether it's invoked as 'bash' or > 'sh', so I changed this to (which "sh") to be safe. I thought I found that sh-> "bash" substitution quite often, for example he= re in nginx: http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/web.scm#n148 >=20 > > + #t))))) > > + (inputs > > + `(("glib" ,glib))) > > + (home-page "https://geos.osgeo.org/") > > + (synopsis "Geometry Engine - Open Source") =20 >=20 > We try to avoid terms like "open source" or "free software" since it's > implied in the context of Guix. OK, maybe that synopsis was a bit short, because "Geometry Engine - Open So= urce" is just the long name of GEOS. >=20 > > + (description > > + "GEOS (Geometry Engine - Open Source) is a C++ port of the > > +Java Topology Suite (JTS). As such, it aims to contain the > > complete +functionality of JTS in C++. This includes all the > > OpenGIS Simple Features +for SQL spatial predicate functions and > > spatial operators, +as well as specific JTS enhanced topology > > functions.") =20 >=20 > I took inspiration from Debians description of this package and > tweaked it a little. >=20 > > + (license license:lgpl2.1))) =20 >=20 > The files do not mention whether it's 2.1 only or later versions so we > default to "or later". Also found a few files with other licenses. I also found no mentioning of "later" or not, so I thought to stick with the mentioned license version. What makes you use the "or later" version? >=20 > Pushed as 252611c7c4e72577cd0c91a41e10176f37ac318b !