From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: pre-push signature hook error reporting [was Re: [PATCH v6] gnu: python-sphinx: Update to 1.4.8.] Date: Fri, 20 Jan 2017 20:39:10 -0500 Message-ID: <20170121013910.GC26714@jasmine> References: <20170105161431.9803-1-dannym@scratchpost.org> <878tqpjw93.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <8760lj5eb6.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170113152400.GA24322@jasmine> <20170117031414.GB23513@jasmine> <87o9z1aksp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TRYliJ5NKNqkz5bu" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUkeA-00026t-G8 for guix-devel@gnu.org; Fri, 20 Jan 2017 20:39:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUke7-0003tE-Bo for guix-devel@gnu.org; Fri, 20 Jan 2017 20:39:14 -0500 Content-Disposition: inline In-Reply-To: <87o9z1aksp.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org --TRYliJ5NKNqkz5bu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 20, 2017 at 03:05:42PM +0100, Ludovic Court=E8s wrote: > For the pre-push hook, the overhead seems reasonable (perhaps we could > limit the range to commits after the first signed commit to avoid > looping for no reason?) and an improvement. I agree that it's reasonable and an improvement for the common case of pushing to existing branches; only the new commits' signatures are verified in this case. It's a good idea to limit the range when pushing new branches. It will still fail invariably, but it will fail more quickly. I believe the first signed commit is e3d0fcbf7e55 (gnu: Default to GCC 5.). Due to merges in the history (I think), using `git rev-list` to enumerate the commits from e3d0fcbf7e55^..HEAD gives a list of commits begins with aae03c484f21832 (gnu: Add singular.), which is an earlier commit. That's a little confusing, but maybe it doesn't matter if we are just trying to save the user some time before it fails. They'll have to disable the hook to push a branch anyways. WDYT? > Eventually we could rewrite in Scheme using guile-git, which should be > faster (no need to fork that much). Yes, that would be good! --TRYliJ5NKNqkz5bu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAliCu74ACgkQJkb6MLrK fwjCbA//XT31bqjyuQRhpNkM97x2Rjm0kjJK7nZsjl6danAatJwCHtsMECB0I/mK 5pfIRbs7VgkqP27Ix5kiX1QIyXObyY9SFZXmCk9+FIIZr8meHL53T6xBXw6ZVzhq wd5IAOt/cbIa1RpNIgbRVCsdzbBdGEzMmtgbDoeBApm7qf/VV8zeIwSVfhNNF7i8 xRLYaNjqiY4D7t6cc5MxZ9p14rdITxUaUtt3sIxc36svaAkPbpTvPYLZfN0obrtj 0rVo1fS050enE6pcOvNrGB0vZpdr0y3BurlSJLPhqWi72VD8Lcw4gkrP1jvQLTHa wEUlyl1vVbzntMUme1i7yIjDj4WJQlvsiEBgrtD1t8c3WqIJ0omVoe1kiCMHyN1h 8wKQ8m+DLnTas7Ox91i1hyV9ngn6jpVu0YtEI5fKhJajd0KIZX4hXVBSutG2pt11 SqHqU7tKjDqQGE3jPgShcoTb21k+s+TShuKfbSQuACWLMWihHRpgpnCKUYjc/fpi ye9aAnHOKZ6tqRPfginaox3u8euRuD//x6NaTnkZeOlffNvc8H1GvTDmQuMf4Xtm Sm/MNXVYBiey49kpDs+qAJCTN6kqdL0NqxxGKQbC2Wl/36mrtX2jLdmxtr0W3Rly m2ZXcf0w29LwStdLoxKmQcj281/yhlJukPff4/QwwCHTiW0vezA= =ew9B -----END PGP SIGNATURE----- --TRYliJ5NKNqkz5bu--