* Add reducelcs.
@ 2017-01-19 11:52 contact.ng0
2017-01-19 11:52 ` [PATCH] gnu: " contact.ng0
0 siblings, 1 reply; 7+ messages in thread
From: contact.ng0 @ 2017-01-19 11:52 UTC (permalink / raw)
To: guix-devel
This adds reducelcs, rebased the patch since it has aparently been ignored since semptember.
The home-page links to a list of applications which provides a link to the source code on github, should be switched to the repository url if this is wrong.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] gnu: Add reducelcs.
2017-01-19 11:52 Add reducelcs contact.ng0
@ 2017-01-19 11:52 ` contact.ng0
2017-01-29 18:53 ` Kei Kebreau
0 siblings, 1 reply; 7+ messages in thread
From: contact.ng0 @ 2017-01-19 11:52 UTC (permalink / raw)
To: guix-devel; +Cc: ng0
From: ng0 <ng0@we.make.ritual.n0.is>
* gnu/packages/lcs.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add lcs.scm.
---
gnu/local.mk | 1 +
gnu/packages/lcs.scm | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 68 insertions(+)
create mode 100644 gnu/packages/lcs.scm
diff --git a/gnu/local.mk b/gnu/local.mk
index 217d31712..0e915cb32 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -203,6 +203,7 @@ GNU_SYSTEM_MODULES = \
%D%/packages/key-mon.scm \
%D%/packages/kodi.scm \
%D%/packages/language.scm \
+ %D%/packages/lcs.scm \
%D%/packages/ldc.scm \
%D%/packages/lego.scm \
%D%/packages/less.scm \
diff --git a/gnu/packages/lcs.scm b/gnu/packages/lcs.scm
new file mode 100644
index 000000000..6b00098ae
--- /dev/null
+++ b/gnu/packages/lcs.scm
@@ -0,0 +1,67 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages lcs)
+ #:use-module ((guix licenses) #:prefix license:)
+ #:use-module (guix packages)
+ #:use-module (gnu packages)
+ #:use-module (gnu packages maths)
+ #:use-module (guix git-download)
+ #:use-module (guix build-system gnu))
+
+(define-public reducelcs
+ ;; This is the last commit which is available upstream, no
+ ;; tarball release happened since 2010.
+ (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
+ (revision "1"))
+ (package
+ (name "reducelcs")
+ (version (string-append "0.0.0-" revision "." (string-take commit 7)))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/gdv/Reduce-Expand-for-LCS")
+ (commit commit)))
+ (file-name (string-append name "-" version "-checkout"))
+ (sha256
+ (base32
+ "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("openlibm" ,openlibm)))
+ (arguments
+ `(#:tests? #f ; no tests
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; no configure script
+ (replace 'install ; no install phase either
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin")))
+ (install-file "Approximation" bin)
+ (install-file "CollectResults" bin)
+ (install-file "GenerateInstances" bin)
+ #t))))))
+ (synopsis "Approximate Longest Commons Subsequence computation tool")
+ (description
+ "@code{reduceLCS} is an implementation of the Reduce-Expand
+algorithm for LCS. It is a fast program to compute the approximate
+Longest Commons Subsequence of a set of strings.")
+ (home-page "http://gianluca.dellavedova.org/software/")
+ (license license:gpl2))))
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] gnu: Add reducelcs.
2017-01-19 11:52 ` [PATCH] gnu: " contact.ng0
@ 2017-01-29 18:53 ` Kei Kebreau
2017-01-29 21:12 ` ng0
0 siblings, 1 reply; 7+ messages in thread
From: Kei Kebreau @ 2017-01-29 18:53 UTC (permalink / raw)
To: contact.ng0; +Cc: guix-devel, ng0
[-- Attachment #1: Type: text/plain, Size: 4353 bytes --]
contact.ng0@cryptolab.net writes:
> From: ng0 <ng0@we.make.ritual.n0.is>
>
> * gnu/packages/lcs.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add lcs.scm.
What do you think necessitates the creation of a new file for this
package? It seems to me it would fit in maths.scm, but I may just be ignorant.
> ---
> gnu/local.mk | 1 +
> gnu/packages/lcs.scm | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 68 insertions(+)
> create mode 100644 gnu/packages/lcs.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 217d31712..0e915cb32 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -203,6 +203,7 @@ GNU_SYSTEM_MODULES = \
> %D%/packages/key-mon.scm \
> %D%/packages/kodi.scm \
> %D%/packages/language.scm \
> + %D%/packages/lcs.scm \
> %D%/packages/ldc.scm \
> %D%/packages/lego.scm \
> %D%/packages/less.scm \
> diff --git a/gnu/packages/lcs.scm b/gnu/packages/lcs.scm
> new file mode 100644
> index 000000000..6b00098ae
> --- /dev/null
> +++ b/gnu/packages/lcs.scm
> @@ -0,0 +1,67 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages lcs)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix packages)
> + #:use-module (gnu packages)
> + #:use-module (gnu packages maths)
> + #:use-module (guix git-download)
> + #:use-module (guix build-system gnu))
> +
> +(define-public reducelcs
> + ;; This is the last commit which is available upstream, no
> + ;; tarball release happened since 2010.
> + (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
> + (revision "1"))
> + (package
> + (name "reducelcs")
> + (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/gdv/Reduce-Expand-for-LCS")
> + (commit commit)))
> + (file-name (string-append name "-" version "-checkout"))
> + (sha256
> + (base32
> + "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("openlibm" ,openlibm)))
> + (arguments
> + `(#:tests? #f ; no tests
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; no configure script
> + (replace 'install ; no install phase either
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin")))
> + (install-file "Approximation" bin)
> + (install-file "CollectResults" bin)
> + (install-file "GenerateInstances" bin)
> + #t))))))
> + (synopsis "Approximate Longest Commons Subsequence computation tool")
> + (description
> + "@code{reduceLCS} is an implementation of the Reduce-Expand
> +algorithm for LCS. It is a fast program to compute the approximate
> +Longest Commons Subsequence of a set of strings.")
> + (home-page "http://gianluca.dellavedova.org/software/")
I think you can link to the Github repo here. Lots of other packages do that.
> + (license license:gpl2))))
The most recent version of this software is covered by the GPLv3 (and
later? IANAL).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] gnu: Add reducelcs.
2017-01-29 18:53 ` Kei Kebreau
@ 2017-01-29 21:12 ` ng0
2017-01-30 6:27 ` reducelcs, v3 contact.ng0
0 siblings, 1 reply; 7+ messages in thread
From: ng0 @ 2017-01-29 21:12 UTC (permalink / raw)
To: Kei Kebreau; +Cc: guix-devel
Kei Kebreau <kei@openmailbox.org> writes:
> contact.ng0@cryptolab.net writes:
>
>> From: ng0 <ng0@we.make.ritual.n0.is>
>>
>> * gnu/packages/lcs.scm: New file.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add lcs.scm.
>
> What do you think necessitates the creation of a new file for this
> package? It seems to me it would fit in maths.scm, but I may just be ignorant.
Okay with this change. I've just resent due to the lack of review
I got on this since the commit date in the patch.
>> ---
>> gnu/local.mk | 1 +
>> gnu/packages/lcs.scm | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 68 insertions(+)
>> create mode 100644 gnu/packages/lcs.scm
>>
>> diff --git a/gnu/local.mk b/gnu/local.mk
>> index 217d31712..0e915cb32 100644
>> --- a/gnu/local.mk
>> +++ b/gnu/local.mk
>> @@ -203,6 +203,7 @@ GNU_SYSTEM_MODULES = \
>> %D%/packages/key-mon.scm \
>> %D%/packages/kodi.scm \
>> %D%/packages/language.scm \
>> + %D%/packages/lcs.scm \
>> %D%/packages/ldc.scm \
>> %D%/packages/lego.scm \
>> %D%/packages/less.scm \
>> diff --git a/gnu/packages/lcs.scm b/gnu/packages/lcs.scm
>> new file mode 100644
>> index 000000000..6b00098ae
>> --- /dev/null
>> +++ b/gnu/packages/lcs.scm
>> @@ -0,0 +1,67 @@
>> +;;; GNU Guix --- Functional package management for GNU
>> +;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
>> +;;;
>> +;;; This file is part of GNU Guix.
>> +;;;
>> +;;; GNU Guix is free software; you can redistribute it and/or modify it
>> +;;; under the terms of the GNU General Public License as published by
>> +;;; the Free Software Foundation; either version 3 of the License, or (at
>> +;;; your option) any later version.
>> +;;;
>> +;;; GNU Guix is distributed in the hope that it will be useful, but
>> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
>> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> +;;; GNU General Public License for more details.
>> +;;;
>> +;;; You should have received a copy of the GNU General Public License
>> +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>> +
>> +(define-module (gnu packages lcs)
>> + #:use-module ((guix licenses) #:prefix license:)
>> + #:use-module (guix packages)
>> + #:use-module (gnu packages)
>> + #:use-module (gnu packages maths)
>> + #:use-module (guix git-download)
>> + #:use-module (guix build-system gnu))
>> +
>> +(define-public reducelcs
>> + ;; This is the last commit which is available upstream, no
>> + ;; tarball release happened since 2010.
>> + (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
>> + (revision "1"))
>> + (package
>> + (name "reducelcs")
>> + (version (string-append "0.0.0-" revision "." (string-take commit 7)))
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/gdv/Reduce-Expand-for-LCS")
>> + (commit commit)))
>> + (file-name (string-append name "-" version "-checkout"))
>> + (sha256
>> + (base32
>> + "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
>> + (build-system gnu-build-system)
>> + (inputs
>> + `(("openlibm" ,openlibm)))
>> + (arguments
>> + `(#:tests? #f ; no tests
>> + #:phases
>> + (modify-phases %standard-phases
>> + (delete 'configure) ; no configure script
>> + (replace 'install ; no install phase either
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (bin (string-append out "/bin")))
>> + (install-file "Approximation" bin)
>> + (install-file "CollectResults" bin)
>> + (install-file "GenerateInstances" bin)
>> + #t))))))
>> + (synopsis "Approximate Longest Commons Subsequence computation tool")
>> + (description
>> + "@code{reduceLCS} is an implementation of the Reduce-Expand
>> +algorithm for LCS. It is a fast program to compute the approximate
>> +Longest Commons Subsequence of a set of strings.")
>> + (home-page "http://gianluca.dellavedova.org/software/")
>
> I think you can link to the Github repo here. Lots of other packages do that.
Yes, that's probably better.
>> + (license license:gpl2))))
>
> The most recent version of this software is covered by the GPLv3 (and
> later? IANAL).
Oh, I will check again.
Thanks!
--
ng0 -- https://www.inventati.org/patternsinthechaos/
^ permalink raw reply [flat|nested] 7+ messages in thread* reducelcs, v3
2017-01-29 21:12 ` ng0
@ 2017-01-30 6:27 ` contact.ng0
2017-01-30 6:27 ` [PATCH] gnu: Add reducelcs contact.ng0
0 siblings, 1 reply; 7+ messages in thread
From: contact.ng0 @ 2017-01-30 6:27 UTC (permalink / raw)
To: guix-devel
Fixed: home-page, license, moved to (gnu packages maths).
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] gnu: Add reducelcs.
2017-01-30 6:27 ` reducelcs, v3 contact.ng0
@ 2017-01-30 6:27 ` contact.ng0
2017-01-30 12:50 ` Kei Kebreau
0 siblings, 1 reply; 7+ messages in thread
From: contact.ng0 @ 2017-01-30 6:27 UTC (permalink / raw)
To: guix-devel; +Cc: ng0
From: ng0 <ng0@we.make.ritual.n0.is>
* gnu/packages/maths.scm (reducelcs): New variable.
---
gnu/packages/maths.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index fbf0f6a54..e939430d5 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -15,6 +15,7 @@
;;; Copyright © 2016 Ludovic Courtès <ludo@gnu.org>
;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
;;; Copyright © 2016 Thomas Danckaert <post@thomasdanckaert.be>
+;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -37,6 +38,7 @@
#:use-module ((guix licenses) #:prefix license:)
#:use-module (guix packages)
#:use-module (guix download)
+ #:use-module (guix git-download)
#:use-module (guix utils)
#:use-module (guix build utils)
#:use-module (guix build-system cmake)
@@ -2840,3 +2842,46 @@ instruction sets. Thus, an application written with Vc can be compiled for:
@end enumerate\n")
(home-page "https://github.com/VcDevel/Vc")
(license license:bsd-3)))
+
+(define-public reducelcs
+ ;; This is the last commit which is available upstream, no
+ ;; release happened since 2010.
+ (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
+ (revision "1"))
+ (package
+ (name "reducelcs")
+ (version (string-append "1.0-" revision "." (string-take commit 7)))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/gdv/Reduce-Expand-for-LCS")
+ (commit commit)))
+ (file-name (string-append name "-" version "-checkout"))
+ (sha256
+ (base32
+ "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
+ (build-system gnu-build-system)
+ (inputs
+ `(("openlibm" ,openlibm)))
+ (arguments
+ `(#:tests? #f ; no tests
+ #:phases
+ (modify-phases %standard-phases
+ (delete 'configure) ; No configure script exists.
+ (replace 'install ; No install phase exists.
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (bin (string-append out "/bin")))
+ (install-file "Approximation" bin)
+ (install-file "CollectResults" bin)
+ (install-file "GenerateInstances" bin)
+ #t))))))
+ (synopsis "Approximate Longest Commons Subsequence computation tool")
+ (description
+ "@code{reduceLCS} is an implementation of the Reduce-Expand
+algorithm for LCS. It is a fast program to compute the approximate
+Longest Commons Subsequence of a set of strings.")
+ (home-page "https://github.com/gdv/Reduce-Expand-for-LCS")
+ ;; The source specifies no "and later" of GPL3.
+ (license license:gpl3))))
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] gnu: Add reducelcs.
2017-01-30 6:27 ` [PATCH] gnu: Add reducelcs contact.ng0
@ 2017-01-30 12:50 ` Kei Kebreau
0 siblings, 0 replies; 7+ messages in thread
From: Kei Kebreau @ 2017-01-30 12:50 UTC (permalink / raw)
To: contact.ng0; +Cc: guix-devel, ng0
[-- Attachment #1: Type: text/plain, Size: 3288 bytes --]
contact.ng0@cryptolab.net writes:
> From: ng0 <ng0@we.make.ritual.n0.is>
>
> * gnu/packages/maths.scm (reducelcs): New variable.
> ---
> gnu/packages/maths.scm | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index fbf0f6a54..e939430d5 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -15,6 +15,7 @@
> ;;; Copyright © 2016 Ludovic Courtès <ludo@gnu.org>
> ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
> ;;; Copyright © 2016 Thomas Danckaert <post@thomasdanckaert.be>
> +;;; Copyright © 2017 ng0 <contact.ng0@cryptolab.net>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -37,6 +38,7 @@
> #:use-module ((guix licenses) #:prefix license:)
> #:use-module (guix packages)
> #:use-module (guix download)
> + #:use-module (guix git-download)
> #:use-module (guix utils)
> #:use-module (guix build utils)
> #:use-module (guix build-system cmake)
> @@ -2840,3 +2842,46 @@ instruction sets. Thus, an application written with Vc can be compiled for:
> @end enumerate\n")
> (home-page "https://github.com/VcDevel/Vc")
> (license license:bsd-3)))
> +
> +(define-public reducelcs
> + ;; This is the last commit which is available upstream, no
> + ;; release happened since 2010.
> + (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
> + (revision "1"))
> + (package
> + (name "reducelcs")
> + (version (string-append "1.0-" revision "." (string-take commit 7)))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/gdv/Reduce-Expand-for-LCS")
> + (commit commit)))
> + (file-name (string-append name "-" version "-checkout"))
> + (sha256
> + (base32
> + "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
> + (build-system gnu-build-system)
> + (inputs
> + `(("openlibm" ,openlibm)))
> + (arguments
> + `(#:tests? #f ; no tests
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure) ; No configure script exists.
> + (replace 'install ; No install phase exists.
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin")))
> + (install-file "Approximation" bin)
> + (install-file "CollectResults" bin)
> + (install-file "GenerateInstances" bin)
> + #t))))))
> + (synopsis "Approximate Longest Commons Subsequence computation tool")
> + (description
> + "@code{reduceLCS} is an implementation of the Reduce-Expand
> +algorithm for LCS. It is a fast program to compute the approximate
> +Longest Commons Subsequence of a set of strings.")
> + (home-page "https://github.com/gdv/Reduce-Expand-for-LCS")
> + ;; The source specifies no "and later" of GPL3.
> + (license license:gpl3))))
LGTM. Pushed to master as 54052a54c1188002b2040b8b24f8605d1c0fac1f.
Thanks again!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-30 12:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 11:52 Add reducelcs contact.ng0
2017-01-19 11:52 ` [PATCH] gnu: " contact.ng0
2017-01-29 18:53 ` Kei Kebreau
2017-01-29 21:12 ` ng0
2017-01-30 6:27 ` reducelcs, v3 contact.ng0
2017-01-30 6:27 ` [PATCH] gnu: Add reducelcs contact.ng0
2017-01-30 12:50 ` Kei Kebreau
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).