unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v2 3/6] gnu: Add python-dulwich.
Date: Thu, 19 Jan 2017 10:34:36 +0100	[thread overview]
Message-ID: <20170119103436.187f97a5@scratchpost.org> (raw)
In-Reply-To: <87y3y88dj5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

> Why is this necessary? Git is available in PATH, no?

Yes, but their tests use Popen with a custom environment which doesn't include the PATH variable at all.

Also, if one messes it up the git invocation tests will be skipped and "succeed"!

  parent reply	other threads:[~2017-01-19  9:34 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 23:30 [PATCH] guix: python-build-system: Properly inform caller about test status Danny Milosavljevic
2017-01-05 10:14 ` Hartmut Goebel
2017-01-05 13:31 ` Marius Bakke
2017-01-05 15:49   ` Leo Famulari
2017-01-05 16:06   ` python-tests: Sphinx Danny Milosavljevic
2017-01-05 16:11     ` Marius Bakke
2017-01-18  7:52       ` [PATCH v2 0/6] Make python-oslosphinx work in python-tests branch Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0 Danny Milosavljevic
2017-01-18 17:39           ` Marius Bakke
2017-01-19  9:28             ` Danny Milosavljevic
2017-01-19 12:59               ` Marius Bakke
2017-01-19 14:34                 ` python2-traceback2, python2-linecache2 Danny Milosavljevic
2017-01-19 15:01                   ` Marius Bakke
2017-01-19 17:46                     ` Marius Bakke
2017-01-20 19:56                       ` 'python-tests' merge Marius Bakke
2017-01-19 20:38                     ` python2-traceback2, python2-linecache2 Hartmut Goebel
2017-01-19 20:35                   ` Hartmut Goebel
2017-01-19 15:31           ` [PATCH v2 1/6] gnu: python-testtools: Update to 1.4.0 Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 2/6] gnu: Add python-fastimport Danny Milosavljevic
2017-01-18 17:39           ` Marius Bakke
2017-01-18 23:43             ` Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 3/6] gnu: Add python-dulwich Danny Milosavljevic
2017-01-18 17:48           ` Marius Bakke
2017-01-18 20:57             ` Efraim Flashner
2017-01-19  9:38               ` Danny Milosavljevic
2017-01-19  9:34             ` Danny Milosavljevic [this message]
2017-01-19 15:27             ` Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 4/6] gnu: Add python-reno Danny Milosavljevic
2017-01-18 17:51           ` Marius Bakke
2017-01-19 15:40           ` Danny Milosavljevic
2017-01-19 16:32           ` Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 5/6] gnu: python-mox3: Remove python-oslosphinx dependency (since the tests don't run anyway) Danny Milosavljevic
2017-01-18 17:54           ` Marius Bakke
2017-01-18 23:42             ` Danny Milosavljevic
2017-01-18  7:53         ` [PATCH v2 6/6] gnu: python-sphinx: Update to 1.5.1 and enable tests Danny Milosavljevic
2017-01-18 17:55           ` Marius Bakke
2017-01-18 23:35             ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170119103436.187f97a5@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).