From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: [PATCH 00/10] ocaml patches Date: Thu, 19 Jan 2017 09:56:56 +0100 Message-ID: <20170119095630.558b8391@lepiller.eu> References: <20170118202802.5073-1-julien@lepiller.eu> <87pojk6m2t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cU8Wv-0000q9-Dw for guix-devel@gnu.org; Thu, 19 Jan 2017 03:57:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cU8Wq-0002E0-IR for guix-devel@gnu.org; Thu, 19 Jan 2017 03:57:13 -0500 Received: from dau94-h03-89-91-205-84.dsl.sta.abo.bbox.fr ([89.91.205.84]:40328 helo=skaro.lepiller.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cU8Wq-0002BP-4O for guix-devel@gnu.org; Thu, 19 Jan 2017 03:57:08 -0500 Received: from localhost (localhost [127.0.0.1]) by skaro.lepiller.eu (Postfix) with ESMTP id 29E377FC8C for ; Thu, 19 Jan 2017 09:57:05 +0100 (CET) Received: from skaro.lepiller.eu ([127.0.0.1]) by localhost (lepiller.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A1EKxB_j_46V for ; Thu, 19 Jan 2017 09:57:01 +0100 (CET) Received: from localhost (128-79-116-134.hfc.dyn.abo.bbox.fr [128.79.116.134]) by skaro.lepiller.eu (Postfix) with ESMTPSA id B33117F91A for ; Thu, 19 Jan 2017 09:57:00 +0100 (CET) In-Reply-To: <87pojk6m2t.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org On Wed, 18 Jan 2017 23:27:06 +0100 Marius Bakke wrote: > Julien Lepiller writes: > > > Here are the next 10 ocaml-related patches I would like to push. > > What do you think? > > I don't know anything about ocaml, but the patches reads fine to me. > > One thing that strikes me is the usage of native-inputs; I assume it's > because the packages are not referenced, but bear in mind that they > are built for the architecture of the build machine, and not for the > target system. I use native-inputs because the build system needs binaries (not libraries) from these packages. > > E.g. `guix build --system=i686-linux ocamlify` will add 64-bit > native-inputs even if the final product is supposed to be 32-bit. Not > sure if that will cause problems or not. Just to be sure, I'll cross-compile them. I'll send updated patches soon. > > > I'm pretty sure number 9 and 10 can be improved, any idea? > > Not from me, I'd say it looks fine :-) Thanks for your review :)