From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH v2 3/6] gnu: Add python-dulwich. Date: Wed, 18 Jan 2017 22:57:00 +0200 Message-ID: <20170118205700.GD14209@macbook42.flashner.co.il> References: <8737gxxza3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170118075305.29573-1-dannym@scratchpost.org> <20170118075305.29573-4-dannym@scratchpost.org> <87y3y88dj5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TU+u6i6jrDPzmlWF" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxI5-0004lx-2G for guix-devel@gnu.org; Wed, 18 Jan 2017 15:57:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTxI1-0001jw-1Y for guix-devel@gnu.org; Wed, 18 Jan 2017 15:57:09 -0500 Received: from flashner.co.il ([178.62.234.194]:57541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTxI0-0001jX-NR for guix-devel@gnu.org; Wed, 18 Jan 2017 15:57:04 -0500 Content-Disposition: inline In-Reply-To: <87y3y88dj5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --TU+u6i6jrDPzmlWF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 18, 2017 at 06:48:46PM +0100, Marius Bakke wrote: > Danny Milosavljevic writes: >=20 > > * gnu/packages/python.scm (python-dulwich, python2-dulwich): New variab= les. > > --- > > gnu/packages/python.scm | 44 +++++++++++++++++++++++++++++++++++++++++= +++ > > 1 file changed, 44 insertions(+) > > > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > index 6c7a6353d..b064c9f47 100644 > > --- a/gnu/packages/python.scm > > +++ b/gnu/packages/python.scm > > @@ -12740,3 +12740,47 @@ Features: > > @item Compiles templates into optimized, yet readable, Python code. > > @end enumerate") > > (license (license:x11-style "file://LICENSE")))) > > + > > +(define-public python-dulwich > > + (package > > + (name "python-dulwich") > > + (version "0.16.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (pypi-uri "dulwich" version)) >=20 > Upstream provides the same releaases on their home page. I would add >=20 > (uri (list (string-append "https://www.dulwich.io/releases/dulwich-" > version ".tar.gz") > (pypi-uri "cram" version))) >=20 > > + (sha256 > > + (base32 "0fl47vzfgc3w3rmhn8naii905cjqcp0vc68iyvymxp7567hh6al= s")))) > > + (build-system python-build-system) > > + (arguments > > + `(#:phases > > + (modify-phases %standard-phases > > + (add-before 'check 'fix-tests > > + (lambda* (#:key inputs #:allow-other-keys) > > + (substitute* "dulwich/tests/compat/utils.py" > > + (("'git'") (string-append "'" > > + (assoc-ref inputs "git") > > + "/bin/git'"))) >=20 > Why is this necessary? Git is available in PATH, no? or alternatively, would (which "git") work? >=20 > > + (substitute* '("dulwich/tests/test_repository.py" > > + "dulwich/tests/test_hooks.py") > > + (("#!/bin/sh") (string-append "#!" (which "sh")))) > > + (setenv "TEST_RUNNER" "unittest") > > + (setenv "PYTHONHASHSEED" "random") > > + #t))))) > > + (propagated-inputs > > + `(("python-fastimport" ,python-fastimport))) > > + (native-inputs > > + `(("python-mock" ,python-mock) > > + ("python-geventhttpclient" ,python-geventhttpclient) > > + ("git" ,git))) > > + (home-page "https://www.dulwich.io/") > > + (synopsis "Git implementation in Python") > > + (description "Dulwich is an implementation of the Git file formats= and > > +protocols written in pure Python.") > > + ;; dual-licensed > > + (license (list license:asl2.0 license:gpl2+)))) >=20 > Please clarify whether it's both, or either. Otherwise LGTM, thanks! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TU+u6i6jrDPzmlWF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkVdB/rIvpOM7bo+N9MHTkX6s7pMFAlh/1psACgkQ9MHTkX6s 7pNXZRAAm0+pU6ZeIqaadEfSikTMfLcLm2rnIF+VQ1ZU/VJRscgEHJqRyMnsIYqO 14wNJ+y4557g0xJDnf0oX6yh4Qskp/Lv3ISZRMaAfQqgqHvMGdOegyHGxTgrgqnu 6u7m9i04JPAbzBv32p8lUG2oA4ZX23RrDUa274/1reKnuSYO/jr9K80QBdWXfbE0 BJE5/roTZsLnD7n0sza9aAmAk81HwIgIh90woJq8ZqMYr0AAJi7ufLOulYkkTliu m3lbgRsSC/BKZYOTDGRwVCUdP26aCJzH6SWdpjBRP/jS+Mz/YUmIc8qlRLZMTne9 7lqI61aOV6oatsvjxo4WMilWBnu/8z5047X4XZzC7ItLrfk2x7k1U7pWea3JEnM+ nXswH16awKxdeBNeNwyak232I1CbpqZY/spZVEcZUjsOjIUft0sSwj2vU/OHyAiD aOzExjGwVBsT6gkCGzz/wSjEXJ75jpXtbb616kYGQI5uUGHaZw54dF2cdJzXGZED WDyaEaaMwiAohSf/5fgSMhlZNdv6T7Fghc28pRdNWJzqQ+1mMYuGHS8Kkpwgd03s CdPX+lvjgRnrFAULqYJsXmi/SUjsp4TtH93g8IvRNM4d2xJtFpNbVW2ilItdLDsP 4wQ3H7HFPpJ1aLn2Ul3J6cY+LQF+/RMNHHFeOdhf2dbc7BeMcoo= =k1lP -----END PGP SIGNATURE----- --TU+u6i6jrDPzmlWF--