From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 8/8] gnu: python-dulwich: Fix tests.
Date: Tue, 17 Jan 2017 23:58:40 +0100
Message-ID: <20170117235837.12de5c67@scratchpost.org>
References: <gu878tqpjw93.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
	<20170117222548.13995-1-dannym@scratchpost.org>
	<20170117222548.13995-9-dannym@scratchpost.org>
	<87wpdt9tzd.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cTciI-0008Id-9B
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:58:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cTciE-0000Jx-9P
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:58:50 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:34927)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cTciE-0000JO-2Z
	for guix-devel@gnu.org; Tue, 17 Jan 2017 17:58:46 -0500
In-Reply-To: <87wpdt9tzd.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

Hi,

On Tue, 17 Jan 2017 23:55:50 +0100
Marius Bakke <mbakke@fastmail.com> wrote:
> > +             (setenv "TEST_RUNNER" "unittest")
> > +             (setenv "PYTHONHASHSEED" "random")
> > +             (and
> > +               ;; Test without c extensions
> > +               ;; FIXME someone already called build_ext.
> > +               ;(zero? (system* "python" "-m" "unittest" "dulwich.tests.test_suite"))
> > +               ;; Test with c extensions
> > +               ;(zero? (system* "python" "setup.py" "build_ext" "-i"))  
> 
> I think build_ext is called as part of the regular build process. Why
> does it need to be called again (with the -i flag)?

It's copied from the .travis file. Since we install the C extension so we should also test the C extension - and the other test doesn't matter. But I'm unsure whether to leave the comment in.