From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog.
Date: Mon, 16 Jan 2017 15:21:29 +0100
Message-ID: <20170116152125.0f011148@scratchpost.org>
References: <20170114185652.29952-1-theodoros.for@openmailbox.org>
	<20170114185652.29952-2-theodoros.for@openmailbox.org>
	<20170114202524.0f056d54@scratchpost.org>
	<87tw8zs49o.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cT8AI-0003Hx-6f
	for guix-devel@gnu.org; Mon, 16 Jan 2017 09:21:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cT8AE-0008UC-SA
	for guix-devel@gnu.org; Mon, 16 Jan 2017 09:21:42 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:50586)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cT8AE-0008U1-L2
	for guix-devel@gnu.org; Mon, 16 Jan 2017 09:21:38 -0500
In-Reply-To: <87tw8zs49o.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: Guix-devel <guix-devel@gnu.org>

Hi,

> I should have probably added a different phase for the
> "icebox/icebox_vlog.py" substitution, to make clear it's the only path
> which is a run-time reference. The installed icebox_vlog, can't find the
> chipdb.txt file, if we don't make the substitution.

Yeah, I think how you did it now is best.

LGTM!

I've built it and it works.

I'll leave some time for others to comment. Afterwards, I'll commit it to master (since it'll cause rebuild of one icestorm-dependent package).