From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Mark /gnu/store as needed for boot. Date: Fri, 13 Jan 2017 12:01:07 +0100 Message-ID: <20170113110107.GA20633@jocasta.intra> References: <1484164902-10160-1-git-send-email-jmd@gnu.org> <87eg07xrmf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cRzbk-0007Fr-Iy for guix-devel@gnu.org; Fri, 13 Jan 2017 06:01:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cRzbj-000115-O2 for guix-devel@gnu.org; Fri, 13 Jan 2017 06:01:20 -0500 Content-Disposition: inline In-Reply-To: <87eg07xrmf.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel@gnu.org, John Darrington --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 13, 2017 at 12:59:20AM -0800, Chris Marusich wrote: Is this procedure supposed to work with relative paths? I get strange results for "foo/bar": No. It was not indended to be passed a relative path. I cannot see what m= eaning that would have - it raises the question "relative to what?". However if s= omehow we can define what it means to pass the procedure a relative path, then I s= uppose it could be modified to work. =20 It seems to me like we could just use 'string-prefix?' here instead. = Am I missing something? Is it really necessary to define an 'all-subpath= s' procedure and use 'member' if 'string-prefix?' is good enough? Well, (string-prefix? "/dev/net" "/dev/networking") would return #t, but the former is not an ancestor of the other. =20 The title of this patch is "Mark /gnu/store as needed for boot." I can see how this change makes that happen. But what is the purpose? I imagine that in some cases, if you don't do this, the initrd might not mount the file system containing the store, which of course would not = be good. Do you have a specific problem case in mind? Yes. I tried installing GuixSD with /gnu/store on a different partition to / The installation seemed to go ok, but it failed to boot, presumably because= =20 lots of essential things (such as the kernel!) are in /gnu/store J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlh4s3MACgkQimdxnC3oJ7PcwgCggi/kKOPN7a4756/yOff7usk6 5JwAn33DzlQodeFgxacD5ORSXPIimPxK =W7Bh -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--