From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add kakoune Date: Tue, 10 Jan 2017 17:26:11 -0500 Message-ID: <20170110222611.GA8431@jasmine> References: <87zijekrns.fsf@zancanaro.id.au> <87y3yykov6.fsf@zancanaro.id.au> <20161230192556.GA2668@jasmine> <87wpehkns6.fsf@zancanaro.id.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cR4rx-0002ez-Cb for guix-devel@gnu.org; Tue, 10 Jan 2017 17:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cR4ru-0004IO-8G for guix-devel@gnu.org; Tue, 10 Jan 2017 17:26:17 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50005) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cR4ru-0004Gh-2z for guix-devel@gnu.org; Tue, 10 Jan 2017 17:26:14 -0500 Content-Disposition: inline In-Reply-To: <87wpehkns6.fsf@zancanaro.id.au> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Carlo Zancanaro Cc: guix-devel --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 31, 2016 at 10:19:53AM +1100, Carlo Zancanaro wrote: > On Fri, Dec 30 2016, Leo Famulari wrote > >> diff --git a/gnu/packages/patches/kakoune-fix-bash-path.patch b/gnu/pa= ckages/patches/kakoune-fix-bash-path.patch > >> diff --git a/gnu/packages/patches/kakoune-leave-manpages-uncompressed.= patch b/gnu/packages/patches/kakoune-leave-manpages-uncompressed.patch > > In this case, we need to explain why upstream's approach of finding a > > POSIX shell doesn't work. >=20 > Perhaps you can give me a hint on this. I've patched it myself because > the original code uses confstr with _CS_PATH, but within the build > environment (and presumably outside of it, too) it gives back > "/bin:/usr/bin". Within the build environment this is invalid (as > neither directory exists), so the tests all fail. There is a bug[1] > about this already, but it was closed without fixing the issue (due to > some complexity/ambiguity in doing so, and no immediate need to fix it). How about this? (add-before 'configure 'patch-bash-path (lambda* (#:key inputs #:allow-other-keys) (substitute* "src/shell_manager.cc" (("if \\(m_shell.empty\\(\\)\\)" line) (string-append "m_shell =3D \"" (assoc-ref %build-inputs "bash") "/bin/sh\";\n " line))) #t)) It's crude but it seems to work (the tests pass) and it avoids this issue: > > Also, using a patch to get half-way there will cause the source code > > given by `guix build --source` to be unbuildable, right? So, I think we > > should find another way to fix whatever is wrong with the shell-finding > > logic. Perhaps it will require cooperation with the upstream > > maintainers, I don't know. >=20 > I hadn't thought about the effect this would have on `guix build > --source`. That's a fairly big problem. Sorry for the slooooow response! --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlh1X38ACgkQJkb6MLrK fwhbtw/+K0i59uYS2DAGZbm/B8+p84vMXbO6OOUV4UfUdjprouXfr5YxgGGABMAf PC0CvQfY0Wkx5ilCVU21aohRg6ML2d7+No+/AJP4MIGUGQ2gGpwnSnc0ni9BE5SQ fh+tl3QL7LwNC/17ND+5P1SAEwK8Vi8R+vD40F5+/G75tXtdSjBmfId7rpyKbnFG O+KabojoneOLbCi+/nPtPBdIXPwpRknummzxx0pXYOI2Y/cB00QImZwg73mOmWI8 H/9ol2tvTLN5f5njlr4L2h33Id+M+tNKsijAB1mykkPkjM97devuzguMSIM42+0X 2d6c/gmf7J7v/8ESp8Ts8oEdbg8c2LNSm56w0LWXOlkz9X5wCfChRMt+pE6iWyIK 6tpuH5Xq88r69LYTISOkeAG692ISGB9i7IEWLwKcX26b+U+Ep6ofoLbIppv7QztU IIKgD4AOIZ4/coR11C/VsudC7ub7w2wR0BQbr0X88pmhaOMzSn5bNwAJBPQj5BuJ U4OivHMUxrAVmsA6tF3+fnfm40qxYxy9i/JEd7aGXEE75dHdwAPhmQ6s/TrA0Qh+ t2jB8AFptbURHdhNYK0cKQhskU8pInCkbw8UjrZ22fXLr61J/osz3JWhdOTA2fD4 +4hM/vWuCduNRwzGMo1xM6FVmzNOGkFJHqbPoPl2U/hr7glLNSI= =Gtsg -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--