From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python2-cheetah.
Date: Tue, 10 Jan 2017 14:51:09 -0500
Message-ID: <20170110195109.GA1272@jasmine>
References: <20170110000130.8036-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45974)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cR2Ry-0000ny-LV
	for guix-devel@gnu.org; Tue, 10 Jan 2017 14:51:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cR2Rv-0000p3-Ej
	for guix-devel@gnu.org; Tue, 10 Jan 2017 14:51:18 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54814)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cR2Ru-0000mo-VL
	for guix-devel@gnu.org; Tue, 10 Jan 2017 14:51:15 -0500
Content-Disposition: inline
In-Reply-To: <20170110000130.8036-1-dannym@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

On Tue, Jan 10, 2017 at 01:01:30AM +0100, Danny Milosavljevic wrote:
> * gnu/packages/python.scm (python2-cheetah): New variable.

Thanks!

> +    (arguments
> +     `(#:python ,python-2))

Is only Python 2 supported?

> +    (home-page "http://www.cheetahtemplate.org/")

This site doesn't load for me.

> +    (synopsis "Template engine")
> +    (description "Cheetah is a template engine and code generation tool.")

I agree with Hartmut's suggestion.

> +    (license license:expat)))

This license appears to be a unique creation of the Cheetah authors. I
recommend using 'x11-style'.