From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/1] gnu: Add sysstat. Date: Tue, 10 Jan 2017 13:39:12 -0500 Message-ID: <20170110183912.GC28486@jasmine> References: <20170110113321.GO24479@macbook42.flashner.co.il> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cR1KJ-0002zQ-Lo for guix-devel@gnu.org; Tue, 10 Jan 2017 13:39:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cR1KE-0008RH-Ql for guix-devel@gnu.org; Tue, 10 Jan 2017 13:39:19 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cR1KE-0008QX-KP for guix-devel@gnu.org; Tue, 10 Jan 2017 13:39:14 -0500 Content-Disposition: inline In-Reply-To: <20170110113321.GO24479@macbook42.flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel@gnu.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 10, 2017 at 01:33:21PM +0200, Efraim Flashner wrote: > On Sat, Jan 07, 2017 at 02:01:21PM -0500, Leo Famulari wrote: > > * gnu/packages/linux.scm (sysstat): New variable. > > + (add-after 'build 'skip-touching-var > > + (lambda _ > > + (substitute* "Makefile" > > + (("mkdir -p \\$\\(DESTDIR\\)\\$\\(SA_DIR\\)") > > + "")) >=20 > I would add this to the previous line It could go there, but I prefer to keep it on its own line for clarify. The string that is being matches is hard to read. Putting the empty replacement on its own line clearly says "delete that string". > > + (description "The sysstat utilities are a collection of performance > > +monitoring tools for Linux. These include mpstat, iostat, tapestat, c= ifsiostat, > > +pidstat, sar, sadc, sadf and sa.") >=20 > should these be @code{mpstat} ... Done, and pushed! Thanks! > I have lumina packaged locally, it wants iostat from sysstat for some of > its functionality. Awesome, let's get it in GNU Guix :) --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlh1KlAACgkQJkb6MLrK fwjDNA/+PpJziLu3V4dPZa/PHC8HSJbZ03J+YYrpxZv0wqTSEu/6yJOx/FF9QhOR 1oMIqekPv+M4DDgU6C+EmGo9psKFR38BKsK0tDlHcJgRr2Agbf6PVOlaiPbhuOaw otS3YAVgFB5YjEdLvAKgNyisvuTOP9bNnC7IYZ3TWl+ZBXEHxNEMXEsH+2s9XpfW amHL968nx74XbTbMUP+dH/BUqmhH4CmDMffkXFAddLz8F1PJJdHjIHeDbxB1U76+ IF1M2+vWTNXg7fFS2DRmvvPzlGh2nVTnXH2dAnVhRXsCySzau0bbhDGbf2l6rw8V CNvrF3P7Jk89BqYxiz3TxQGpFdLc4GFZMza8//gY55SI0yoYWHkZ7/E2kOHaUnVN 0wjGLj2FmSidQS+QOxxuSh8aXPyMAE+LWADtM/owrcnmOPxB3clzFXU+tXf7+fqz xWGJsVyIDH2TssRUWOrrmo261WXv99UUa34S2+Q5dKKVP6YQi/wXh/WB+MYWA7SL luK3oPq/nNKNCmGPy6tjDYYdBOSB7kWRikb622QyjfC6wpEpFT0MQxcM+3nmQkJV aK3qnnvOc7H3n0LchZmzrzx9T/M8DuoE36yJ8Re7Q7aLo1VyeL0oQjyN/kNy1Avt v4wy2wqM4BQK9T67+1VMT6nLAzgBP+o8LfXN3ZtdQ6TQRVZNtKc= =FzLY -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR--