[PATCH 1/1] gnu: Add sysstat.

[PATCH 1/1] gnu: Add sysstat.

[Leo Famulari]

* gnu/packages/linux.scm (sysstat): New variable.
---
 gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0c191629c..d66c0c9db 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -18,6 +18,7 @@
 ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
 ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
 ;;; Copyright © 2016 ng0 <ng0@libertad.pw>
+;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3271,3 +3272,39 @@ Extensible Firmware Interface (EFI) Boot Manager.  This application can
 create and destroy boot entries, change the boot order, change the next
 running boot option, and more.")
     (license license:gpl2+)))
+
+(define-public sysstat
+  (package
+    (name "sysstat")
+    (version "11.4.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://perso.orange.fr/sebastien.godard/"
+                                  "sysstat-" version ".tar.xz"))
+              (sha256
+               (base32
+                "0f8gk1hma3bk198ziwrhh5jhisnbbgc1v4rxhny58n0zjzw0gm0z"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f ; No test suite.
+       ;; Without this flag, it tries to install the man pages with group 'root'
+       ;; and fails because /etc/passwd lacks an entry for the root user.
+       #:configure-flags
+       (list "--disable-file-attr"
+             (string-append "conf_dir=" (assoc-ref %outputs "out") "/etc"))
+       #:phases
+       (modify-phases %standard-phases
+         ;; The build process tries to create '/var/lib/sa', so we skip that
+         ;; instruction.
+         (add-after 'build 'skip-touching-var
+           (lambda _
+             (substitute* "Makefile"
+               (("mkdir -p \\$\\(DESTDIR\\)\\$\\(SA_DIR\\)")
+                ""))
+             #t)))))
+    (home-page "http://sebastien.godard.pagesperso-orange.fr/")
+    (synopsis "Performance monitoring tools for Linux")
+    (description "The sysstat utilities are a collection of performance
+monitoring tools for Linux.  These include mpstat, iostat, tapestat, cifsiostat,
+pidstat, sar, sadc, sadf and sa.")
+    (license license:gpl2+)))
-- 
2.11.0

Re: [PATCH 1/1] gnu: Add sysstat.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2983 bytes --]

On Sat, Jan 07, 2017 at 02:01:21PM -0500, Leo Famulari wrote:
> * gnu/packages/linux.scm (sysstat): New variable.
> ---
>  gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
> 
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 0c191629c..d66c0c9db 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -18,6 +18,7 @@
>  ;;; Copyright © 2016 Marius Bakke <mbakke@fastmail.com>
>  ;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
>  ;;; Copyright © 2016 ng0 <ng0@libertad.pw>
> +;;; Copyright © 2017 Leo Famulari <leo@famulari.name>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -3271,3 +3272,39 @@ Extensible Firmware Interface (EFI) Boot Manager.  This application can
>  create and destroy boot entries, change the boot order, change the next
>  running boot option, and more.")
>      (license license:gpl2+)))
> +
> +(define-public sysstat
> +  (package
> +    (name "sysstat")
> +    (version "11.4.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://perso.orange.fr/sebastien.godard/"
> +                                  "sysstat-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "0f8gk1hma3bk198ziwrhh5jhisnbbgc1v4rxhny58n0zjzw0gm0z"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; No test suite.
> +       ;; Without this flag, it tries to install the man pages with group 'root'
> +       ;; and fails because /etc/passwd lacks an entry for the root user.
> +       #:configure-flags
> +       (list "--disable-file-attr"
> +             (string-append "conf_dir=" (assoc-ref %outputs "out") "/etc"))
> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; The build process tries to create '/var/lib/sa', so we skip that
> +         ;; instruction.
> +         (add-after 'build 'skip-touching-var
> +           (lambda _
> +             (substitute* "Makefile"
> +               (("mkdir -p \\$\\(DESTDIR\\)\\$\\(SA_DIR\\)")
> +                ""))

I would add this to the previous line

> +             #t)))))
> +    (home-page "http://sebastien.godard.pagesperso-orange.fr/")
> +    (synopsis "Performance monitoring tools for Linux")
> +    (description "The sysstat utilities are a collection of performance
> +monitoring tools for Linux.  These include mpstat, iostat, tapestat, cifsiostat,
> +pidstat, sar, sadc, sadf and sa.")

should these be @code{mpstat} ...

> +    (license license:gpl2+)))
> -- 
> 2.11.0
> 

I have lumina packaged locally, it wants iostat from sysstat for some of
its functionality.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/1] gnu: Add sysstat.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Tue, Jan 10, 2017 at 01:33:21PM +0200, Efraim Flashner wrote:
> On Sat, Jan 07, 2017 at 02:01:21PM -0500, Leo Famulari wrote:
> > * gnu/packages/linux.scm (sysstat): New variable.
> > +         (add-after 'build 'skip-touching-var
> > +           (lambda _
> > +             (substitute* "Makefile"
> > +               (("mkdir -p \\$\\(DESTDIR\\)\\$\\(SA_DIR\\)")
> > +                ""))
> 
> I would add this to the previous line

It could go there, but I prefer to keep it on its own line for clarify.
The string that is being matches is hard to read. Putting the empty
replacement on its own line clearly says "delete that string".

> > +    (description "The sysstat utilities are a collection of performance
> > +monitoring tools for Linux.  These include mpstat, iostat, tapestat, cifsiostat,
> > +pidstat, sar, sadc, sadf and sa.")
> 
> should these be @code{mpstat} ...

Done, and pushed! Thanks!

> I have lumina packaged locally, it wants iostat from sysstat for some of
> its functionality.

Awesome, let's get it in GNU Guix :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]