unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/9] Add more qtmodules
Date: Mon, 9 Jan 2017 18:11:20 -0500	[thread overview]
Message-ID: <20170109231120.GA1437@jasmine> (raw)
In-Reply-To: <20170109100347.29913-1-efraim@flashner.co.il>

On Mon, Jan 09, 2017 at 12:03:38PM +0200, Efraim Flashner wrote:
> While I was working on them, I realized that the test suite wasn't really
> being run. I patched qtsvg to run the test suite (and therefor propagate to
> all the other qt modules), but everything started breaking, due to network
> tests, javascript dependencies, etc., so I've moved that to a separate branch
> locally to work on more later. However, I do think it would be be better to
> enable the tests in qtsvg and then disable them on most of the modules, so
> that way they're ready to be fixed and enabled without waiting for me to
> get around to it. Thoughts?

Sounds like a good plan.

> Efraim Flashner (9):
>   gnu: Add qtdeclarative-render2d.
>   gnu: Add qtserialbus.
>   gnu: Add qtgamepad.
>   gnu: Add qtscxml.
>   gnu: Add qtpurchasing.
>   gnu: Add qtcanvas3d.
>   gnu: Add qtcharts.
>   gnu: Add qtdatavis3d.

These LGTM overall.

>   gnu: Add qt3d.

This one doesn't seem to have been sent.

  parent reply	other threads:[~2017-01-09 23:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 10:03 [PATCH 0/9] Add more qtmodules Efraim Flashner
2017-01-09 10:03 ` [PATCH] gnu: Add python-pypump Efraim Flashner
2017-01-09 11:03   ` Efraim Flashner
2017-01-09 10:03 ` [PATCH 1/9] gnu: Add qtdeclarative-render2d Efraim Flashner
2017-01-09 10:03 ` [PATCH 2/9] gnu: Add qtserialbus Efraim Flashner
2017-01-09 10:03 ` [PATCH 3/9] gnu: Add qtgamepad Efraim Flashner
2017-01-09 10:03 ` [PATCH 4/9] gnu: Add qtscxml Efraim Flashner
2017-01-09 10:03 ` [PATCH 5/9] gnu: Add qtpurchasing Efraim Flashner
2017-01-09 10:03 ` [PATCH 6/9] gnu: Add qtcanvas3d Efraim Flashner
2017-01-09 10:03 ` [PATCH 7/9] gnu: Add qtcharts Efraim Flashner
2017-01-09 10:03 ` [PATCH 8/9] gnu: Add qtdatavis3d Efraim Flashner
2017-01-09 23:11 ` Leo Famulari [this message]
2017-01-10  9:02   ` [PATCH 0/9] Add more qtmodules Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109231120.GA1437@jasmine \
    --to=leo@famulari.name \
    --cc=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).