From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: sed: Update to 4.3. Date: Wed, 4 Jan 2017 15:16:38 -0500 Message-ID: <20170104201638.GC7042@jasmine> References: <20170104160134.28283-1-mbakke@fastmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOrzJ-0000go-0N for guix-devel@gnu.org; Wed, 04 Jan 2017 15:16:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOrzF-0007JA-Pp for guix-devel@gnu.org; Wed, 04 Jan 2017 15:16:44 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47727) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cOrzF-0007IH-KO for guix-devel@gnu.org; Wed, 04 Jan 2017 15:16:41 -0500 Content-Disposition: inline In-Reply-To: <20170104160134.28283-1-mbakke@fastmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 04, 2017 at 05:01:34PM +0100, Marius Bakke wrote: > * gnu/packages/base.scm (sed): Update to 4.3. > [source]: Use xz tarball. Remove upstreamed patch. > [home-page]: Use https. > [native-inputs]: Add perl. > * gnu/packages/patches/sed-hurd-path-max.patch: Delete file. > * gnu/local.mk (dist_patch_DATA): Remove it. Thanks! We should make sure that the built package doesn't retain a reference to Perl. It's interesting that `guix refresh -l sed` doesn't show the full impact of this change: $ guix refresh -l sed Building the following 4 packages would ensure 4 dependent packages are rebuilt: password-store-1.6.5 hydra-20151030.1ff48da bamm-1.7.3 roary-3.7.0 Also, this part of the package definition is incorrect: (substitute* '("testsuite/bsd.sh" "testsuite/bug-regex9.c") (("/bin/sh") (string-append bash "/bin/bash"))) #t))))))) Bash and sh behave differently; the replacement string should refer to '/bin/sh'. Feel free to correct this in your patch, or I will do it in a later commit. Let me know what you decide. --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlhtWCIACgkQJkb6MLrK fwjNshAAyOfK6x8fo8MsjNWGfnFBjayLtRsk5S+pDP5JKQie7KQoiu3vhDfjnwEP p3jUCzqXDrtoY5zOA2HmLnibkkxAc7PsCNcrpK31s7szjrdV51TDc7dVS6zKJyCu qb4TzlCZ/1uEYrNNQHgabvtBoEhB8vRNzczxVRAcg76oyyLd18klWaSEuEzA3YqO xo5/08+tdtT1Uz/lBZPYq/VrJBPBKJunAkbHGF8Cml8ySNzdEJl4dcW/VcJWF+4i UhGZQfiqgmxGBdqzeoZWAbT6GnvlxKYT8Jfk+Mo8x6ds7M6TmSCwECkD0OeIQeZH ADiDenRUWDFoEEqkevqdfpO/AANu//3gGlDf8j4da4IN4zWEdoltJZC+JLLpSIkm 5MJe8CZIdKUaDRleUAmT1jBUz5pMiuheVqZ5hlkQT4yvXM0RCIhb26N9YQ747Lrm gh7iLf7gSdF5pS+pUp+BsXeOqvflc5y3otZDt3iYyNpJaE4ARV+I1lMpMdE3FM9a 0i4vLpPOncKTkFfIub7L1XwnfTNX/sD6VVtwksgsBrBqMMhqlyLeQIkKaH4qhEtd C2n2e/p6MsHV8Ck1yS5r0kScUEuOpcHRtis/qzCoYfDvOCzqJgCoRelgZDcBJd2c YTgNbWHKdjIDFvboxpDAYZoLlYJ/I6Kgsl0Xqgc2cApbGdxXVEs= =w608 -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7--