From: Danny Milosavljevic <dannym@scratchpost.org>
To: David Craven <david@craven.ch>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: WIP patch: build-system: cargo: Make lots and lots of rust packages work
Date: Tue, 3 Jan 2017 12:54:09 +0100 [thread overview]
Message-ID: <20170103125409.095aea4e@scratchpost.org> (raw)
In-Reply-To: <CAL1_im=qAJ_fc8dWNwt6Zoebz5J4PrDHssv4S-v_RGeTHx-vwg@mail.gmail.com>
Hi David,
On Tue, 3 Jan 2017 12:08:56 +0100
David Craven <david@craven.ch> wrote:
> Can you elaborate on why you think it's a bad idea to separate the
> source from the binaries into different outputs?
Huh? I think it's a good idea. It just doesn't work yet and I didn't find out why :)
> I see that you are trying to mimic what cargo vendor does. Cool proof
> of concept and nice solution to the computing sha256 hashes on the
> build side.
Yeah. I thought they can't exactly replace all the bundled files in all the repos (written by anyone) if they ever changed the file format - so it's there to stay "forever". There's no downside I can see.
That said, we can also do it via cargo vendor if it's easy. But it's not really required - we can always just change it to that if it ever breaks.
> The question is if this is the best approach. I was thinking of trying
> [0] first and see how that works for the build system use case. The
> cargo package example using vendoring is intended to be a temporary
> solution, and I'm not sure we have finished exploring the "design
> space" yet.
>
> [0] https://github.com/alexcrichton/cargo-local-registry
That's interesting too! We can try both.
My patch is just a WIP patch of something that works. We should explore the other alternatives, too.
But about the current approach in master, I talked to Alex Crichton [1], he said that the "replace" approach won't work without a registry because it tries to replace crates by the exact same version and what you specify for "replace" is just an API version. I think by then you can just go all the way to a custom registry and dispense of the "replace".
[1] https://github.com/rust-lang/cargo/issues/3476
next prev parent reply other threads:[~2017-01-03 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 2:44 [PATCH] build-system: cargo: Add #:cargo-build-flags keyword argument Danny Milosavljevic
2017-01-03 2:51 ` [PATCH v2] " Danny Milosavljevic
2017-01-03 4:01 ` WIP patch: build-system: cargo: Make lots and lots of rust packages work Danny Milosavljevic
2017-01-03 11:08 ` David Craven
2017-01-03 11:54 ` Danny Milosavljevic [this message]
2017-01-03 11:57 ` Danny Milosavljevic
2017-01-04 1:03 ` WIP v2: " Danny Milosavljevic
2017-01-04 20:19 ` WIP v3: " Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103125409.095aea4e@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).