unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Thomas Danckaert <post@thomasdanckaert.be>
To: dannym@scratchpost.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: doxygen: Use sh from the store.
Date: Tue, 03 Jan 2017 13:51:40 +0100 (CET)	[thread overview]
Message-ID: <20170103.135140.2123433639208115812.post@thomasdanckaert.be> (raw)
In-Reply-To: <20170103132837.3fdb6b1e@scratchpost.org>

From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH] gnu: doxygen: Use sh from the store.
Date: Tue, 3 Jan 2017 13:28:37 +0100

> Thanks for the patch! Looks good to me.
>
> In any case, if we search for "portable_system", we find that there 
> are lots of other things that don't use in-store names:
>
> ./cite.cpp:  if 
> ((exitCode=portable_system("perl","\""+bib2xhtmlFile+"\" 
> "+bibOutputFiles+" \""+
> ./dia.cpp:  if 
> ((exitCode=portable_system(diaExe,diaArgs,FALSE))!=0) // from config
> [...]

AFAIU those could work, because "portable_system()" runs “sh -c” with
the specified command.  So if the executables can be found on the
current PATH, I suppose it will work.

> Aaaah found sprintf without max length specifier.
>
> Dear god is doxygen unsafe. I should refrain from reading the 
> source code of some popular packages - it doesn't end well.

:-) Perhaps this is not so critical, because users likely don't run 
doxygen on arbitrary unverified input data?

Thomas

  reply	other threads:[~2017-01-03 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 12:09 [PATCH] gnu: doxygen: Use sh from the store Thomas Danckaert
2017-01-03 12:28 ` Danny Milosavljevic
2017-01-03 12:51   ` Thomas Danckaert [this message]
2017-01-09 19:37   ` Thomas Danckaert
2017-01-09 20:04     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170103.135140.2123433639208115812.post@thomasdanckaert.be \
    --to=post@thomasdanckaert.be \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).