unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Brandon Ludwig <bldtg@outlook.com>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: arc-theme: Update to 20161119
Date: Mon, 2 Jan 2017 12:10:43 -0500	[thread overview]
Message-ID: <20170102171043.GC12688@jasmine> (raw)
In-Reply-To: <DM2PR10MB0255F0516ABB71935BBC6116A56F0@DM2PR10MB0255.namprd10.prod.outlook.com>

On Mon, Jan 02, 2017 at 07:51:10AM +0000, Brandon Ludwig wrote:
> Hello,
> 
> 
> this patch updates arc-theme to 20161119.

From 3e694bb4e38e6380a2113cb7bc656b85be2aa511 Mon Sep 17 00:00:00 2001
From: bldtg <bldtg@outlook.com>
Date: Sun, 1 Jan 2017 21:30:41 -0900
Subject: [PATCH] gnu: arc-theme: Update to 20161119

Thanks!

Can you clarify which name you want to appear in the Git log? 'bldtg',
'Brandon Ludwig', something else? You can use whatever you want.

Also, the commit message should include a description of the changes at
the "file-level". In this case, that looks like this:

* gnu/packages/gnome.scm (arc-theme): Update to 20161119.

This is what is meant when the manual mentions the GNU ChangeLog format:

https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

I usually look at earlier commits for examples when I'm unsure.

Normally I'd add that line for you when pushing, but since I'm asking
for clarification about which name to use, I figure you can amend the
commit to include this part :)

  reply	other threads:[~2017-01-02 17:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02  7:51 [PATCH] gnu: arc-theme: Update to 20161119 Brandon Ludwig
2017-01-02 17:10 ` Leo Famulari [this message]
     [not found]   ` <DM2PR10MB025552000B87093514ADC078A56F0@DM2PR10MB0255.namprd10.prod.outlook.com>
2017-01-03  5:30     ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102171043.GC12688@jasmine \
    --to=leo@famulari.name \
    --cc=bldtg@outlook.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).