From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add asunder. Date: Sun, 25 Dec 2016 15:03:38 -0500 Message-ID: <20161225200338.GB29608@jasmine> References: <20161217092040.3112-1-cmmarusich@gmail.com> <20161217092040.3112-2-cmmarusich@gmail.com> <20161217185621.GC1726@jasmine> <878trd7gmz.fsf@gmail.com> <87d1gj12nb.fsf@gmail.com> <20161223163640.GA8463@jasmine> <87mvfmnkin.fsf@gmail.com> <20161224070741.GA22948@jocasta.intra> <87mvfkn4se.fsf@gmail.com> <20161225074835.GA9450@jocasta.intra> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLF1D-0003kj-9C for guix-devel@gnu.org; Sun, 25 Dec 2016 15:03:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLF1A-0005xE-0e for guix-devel@gnu.org; Sun, 25 Dec 2016 15:03:43 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38927) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cLF19-0005x6-SW for guix-devel@gnu.org; Sun, 25 Dec 2016 15:03:39 -0500 Content-Disposition: inline In-Reply-To: <20161225074835.GA9450@jocasta.intra> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 25, 2016 at 08:48:35AM +0100, John Darrington wrote: > On Sat, Dec 24, 2016 at 06:03:45PM -0800, Chris Marusich wrote: >=20 > Why is the wrapper not good here? What would be a better solution? > =20 > Here's why I think the wrapper produced by 'wrap-program' is a good > solution in this case: > =20 > * The wrapper script allows us to package the software without modif= ying > its source. As previously explained, Asunder is currently written u= nder > the assumption that the tools it requires will be made available via= the > PATH environment variable. > =20 > * The wrapper script guarantees "complete deployment" of Asunder (i.= e., > no missing dependencies). This is because the wrapper script contai= ns > references to the components in the store that provide the command-l= ine > tools that Asunder requires. > =20 > * The wrapper script requires less work than patching Asunder. > =20 > * The wrapper script is more robust than any patch we might attempt = to > apply to Asunder's source code. > =20 > This is a good argument for using a wrapper script in this case. An= d I > believe these points apply to any component, like Asunder, which is > written under the assumption that tools will be made available via > PATH. I also am willing to believe there are cases where the wrapper > script is undesirable, but I don't think this is one of them. Okay, thanks for explanation. A wrapper does indeed seem appropriate in this case. --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlhgJhkACgkQJkb6MLrK fwjc3hAArUKmZHFxezM+5mVqypSstqnW765CIXydB3Z4zMgpklXTylwuF4kTxjfj O0dvQSv3snJD2DnKJtoQ4ksuFS892UHbW2DNMmb8UQAT5hnG2RNRX8t/KwtXecNO f9y4osBTgJk/dTBUcq4lOl0/yVnMx4wpGtdeYDfoQI2w2vdzOmW8uSJQJDDgyFbS T3pJd54X8OcLRgCjKo27Ck22T5+a1bZX+P9jcnPuLhZSIM+ZF5nU2NXTtlqNIk/8 SAOWrnqXKNQbZO/NnqJiI0T0ul/+GGKydAUHfN+OdADfnVfhjXT5U1/rw+XIvRiN MF2faOS35DQSTt634RRM2HHFzK7aHrbvAie0OOUtqVnJSPjhXcdDlZCaxfwJo2wM mIJgd+uOVOyW9al71sW5cjcks0f9PwMRFGh9eNnXcFHAVqlnuhfQOM+iH4knhLOh uZZ0TL3fT52ibMVHN9sespl2I35+5roUAcWjTjVXvTk42poK+QZYsLypGcbH5Xnc RQ+CmAPyRkCEikrUYFDK3PESNEX7Zh2kksiSpL3CsC1lMGwXUTGFzIjKp++a8l3X YBkvEiXOauRsOvjuknSPwng/q5bypu4TyHQw5ccFCepCQmJkJcpBkUk3vjyXShax VJi0zFT/pzt0GWnD9t1Ebo96uyZ3JwhICXcK+L7ui6kg6qB3fyc= =ES+1 -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--