From: Leo Famulari <leo@famulari.name>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add asunder.
Date: Sat, 17 Dec 2016 13:56:21 -0500 [thread overview]
Message-ID: <20161217185621.GC1726@jasmine> (raw)
In-Reply-To: <20161217092040.3112-2-cmmarusich@gmail.com>
On Sat, Dec 17, 2016 at 01:20:40AM -0800, Chris Marusich wrote:
> * gnu/packages/cdrom.scm (asunder): New variable.
Thanks!
> + (home-page "http://www.littlesvr.ca/asunder/index.php")
I agree with the other reviewers about the home-page.
> + (inputs `(("gtk+-2" ,gtk+-2)
> + ("glib" ,glib)
> + ("libcddb" ,libcddb)
> + ("cdparanoia" ,cdparanoia)
> + ("lame" ,lame)
> + ("vorbis-tools" ,vorbis-tools)
> + ("flac" ,flac)
> + ("opus" ,opus)
> + ("wavpack" ,wavpack)
> + ("libmpcdec" ,libmpcdec)))
I checked the references of the built package:
$ guix gc --references $(./pre-inst-env guix build asunder)
/gnu/store/1jh6z732id8w014i66abm2h2iivkwk8v-gdk-pixbuf+svg-2.34.0
/gnu/store/46kis1wxzqfk3yysaz6ds0pc7w195a3b-gtk+-2.24.31
/gnu/store/4glf79v1r1l4k7by4vf1lfldq7n0yafw-libcddb-1.3.2
/gnu/store/7m55pyfv0rm19rqrrr7xx0c2irsvaq3y-pango-1.40.1
/gnu/store/cd92wyv466fcfnavx3wcjcr8qln4ycix-atk-2.20.0
/gnu/store/cdi08kw7r6r684w8mk0xq0dkgpjhfpmd-gcc-4.9.4-lib
/gnu/store/hmc1jiyr29mk9cl2d9j0jwf0dim1q76g-freetype-2.6.3
/gnu/store/iwgi9001dmmihrjg4rqhd6pa6788prjw-glibc-2.24
/gnu/store/n56vagr3zv7ildvh9b7mzvk7h4bgwjpf-shared-mime-info-1.7
/gnu/store/p56ai0sj3bbh8hdqc9qigdp91gj73brp-glib-2.48.2
/gnu/store/pkv2qqgprp4zxcqfspwwx81qm9lng0da-fontconfig-2.12.1
/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0
/gnu/store/y30l675nz41p87pmvzscqhhyhik626na-cairo-1.14.6
/gnu/store/zfm6sgn6mpv8yqfjwk23i7hnjib2rc30-asunder-2.8
Several inputs are missing from this list, so they will be garbage
collected when the user runs `guix gc`. Can you look into that?
> + ;; Asunder can also encode to AAC using neroAacEnc and to Monkey's audio
> + ;; using mac, but we do not include those libraries as they are non-free.
This comment isn't necessary, in my opinion.
> + (description
> + "Asunder is a graphical Audio CD ripper and encoder. It can save audio
Does audio need to be capitalized here?
next prev parent reply other threads:[~2016-12-17 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 9:20 Add Asunder Chris Marusich
2016-12-17 9:20 ` [PATCH] gnu: Add asunder Chris Marusich
2016-12-17 9:46 ` John Darrington
2016-12-17 16:14 ` Hartmut Goebel
2016-12-17 18:56 ` Leo Famulari [this message]
2016-12-18 9:04 ` Chris Marusich
2016-12-23 8:16 ` Chris Marusich
2016-12-23 16:36 ` Leo Famulari
2016-12-24 2:11 ` Chris Marusich
2016-12-24 7:07 ` John Darrington
2016-12-25 2:03 ` Chris Marusich
2016-12-25 7:48 ` John Darrington
2016-12-25 20:03 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217185621.GC1726@jasmine \
--to=leo@famulari.name \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).