From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 3/3] gnu: python2-notebook: Fix build.
Date: Mon, 5 Dec 2016 16:44:34 -0500
Message-ID: <20161205214434.GC21176@jasmine>
References: <1480940465-15430-1-git-send-email-h.goebel@crazy-compilers.com>
	<1480940465-15430-3-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cE13w-0005ph-FG
	for guix-devel@gnu.org; Mon, 05 Dec 2016 16:44:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cE13r-00019P-Gi
	for guix-devel@gnu.org; Mon, 05 Dec 2016 16:44:40 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:36074)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cE13r-00019I-Cb
	for guix-devel@gnu.org; Mon, 05 Dec 2016 16:44:35 -0500
Content-Disposition: inline
In-Reply-To: <1480940465-15430-3-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Mon, Dec 05, 2016 at 01:21:05PM +0100, Hartmut Goebel wrote:
> * gnu/packages/python.scm (python2-notebook)[properties]: Add
> python2-variant.
> (python2-notebook)[native-packages] add python2-mock. [arguments] Add
> phase "disable-test-case" for disabling a failing test. immediately

s/ immediately//

>  (define-public python2-notebook
> -  (package-with-python2 python-notebook))
> +  (let ((base (package-with-python2
> +                (strip-python2-variant python-notebook))))
> +    (package (inherit base)
> +      (native-inputs
> +       `(("python2-mock" ,python2-mock)
> +         ,@(package-native-inputs base)))
> +      (arguments
> +       (substitute-keyword-arguments (package-arguments base)
> +         ((#:phases phases)
> +          `(modify-phases ,phases
> +             (add-before 'check 'disable-test-case
> +              ;; The test requires network access to localhost. Curiously it
> +              ;; files with Python 2 only. Simply make the test-case return

s/files/fails

Otherwise LGTM, thanks! I was just noticing this issue :)