unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 8/9] gnu: coq: Update to 8.5pl2.
Date: Sat, 3 Dec 2016 15:09:23 -0500	[thread overview]
Message-ID: <20161203200923.GI21416@jasmine> (raw)
In-Reply-To: <20161203104213.8135-8-david@craven.ch>

On Sat, Dec 03, 2016 at 11:42:12AM +0100, David Craven wrote:
> * gnu/packages/ocaml.scm (coq): Update to 8.5pl2.
>   [arguments]: Configure script takes single hyphen arguments.

>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "https://coq.inria.fr/distrib/V" version
> -                                  "/files/" name "-" version ".tar.gz"))
> +              (uri (string-append
> +                    "https://coq.inria.fr/distrib"
> +                    "/V" version "/files/"
> +                    "coq-" version ".tar.gz"))

The URI is unchanged, right? If so, I'd leave this hunk out of the
commit.

Otherwise LGTM.

  reply	other threads:[~2016-12-03 20:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 10:42 [PATCH 1/9] gnu: Add ghc-hinotify David Craven
2016-12-03 10:42 ` [PATCH 2/9] gnu: Add ghc-fsnotify David Craven
2016-12-03 19:59   ` Leo Famulari
2016-12-03 10:42 ` [PATCH 3/9] gnu: Add ghc-tasty-rerun David Craven
2016-12-03 20:00   ` Leo Famulari
2016-12-03 10:42 ` [PATCH 4/9] gnu: Add ghc-ieee754 David Craven
2016-12-03 20:01   ` Leo Famulari
2016-12-10 10:15     ` David Craven
2016-12-03 10:42 ` [PATCH 5/9] gnu: Add ghc-terminal-size David Craven
2016-12-03 20:01   ` Leo Famulari
2016-12-03 10:42 ` [PATCH 6/9] gnu: ghc-trifecta: Update to 1.6 David Craven
2016-12-03 20:02   ` Leo Famulari
2016-12-03 10:42 ` [PATCH 7/9] gnu: idris: Update to 0.12.3 David Craven
2016-12-03 20:03   ` Leo Famulari
2016-12-03 20:26     ` David Craven
2016-12-03 21:06       ` Leo Famulari
2016-12-03 10:42 ` [PATCH 8/9] gnu: coq: Update to 8.5pl2 David Craven
2016-12-03 20:09   ` Leo Famulari [this message]
2016-12-03 10:42 ` [PATCH 9/9] gnu: Add ocaml-menhir David Craven
2016-12-03 19:56   ` Leo Famulari
2016-12-03 20:12   ` Leo Famulari
2016-12-03 19:58 ` [PATCH 1/9] gnu: Add ghc-hinotify Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161203200923.GI21416@jasmine \
    --to=leo@famulari.name \
    --cc=david@craven.ch \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).