From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Add Kerberos client service. Date: Wed, 30 Nov 2016 14:44:18 +0100 Message-ID: <20161130134418.GA21749@jocasta.intra> References: <87shqh500f.fsf@gnu.org> <1480444784-32432-1-git-send-email-jmd@gnu.org> <1480444784-32432-2-git-send-email-jmd@gnu.org> <874m2pktc2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35169) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC5BR-0005mj-TQ for guix-devel@gnu.org; Wed, 30 Nov 2016 08:44:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC5BQ-0000BZ-PJ for guix-devel@gnu.org; Wed, 30 Nov 2016 08:44:25 -0500 Content-Disposition: inline In-Reply-To: <874m2pktc2.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic Court??s Cc: guix-devel@gnu.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 30, 2016 at 02:09:17PM +0100, Ludovic Court??s wrote: John Darrington skribis: =20 > * doc/guix.texi (Kerberos Services)[Krb5 Service]: New subsubheading. > * gnu/services/kerberos.scm (krb5-service-type): New variable. =20 Please mention the configuration.scm changes. ok. =20 > +@subsubheading Krb5 Service > + > +The krb5 service provides the configuration for Kerberos clients, u= sing > +the MIT implementation of the Kerberos protocol version@tie{}5. =20 Please take into account my previous suggestions: =20 https://lists.gnu.org/archive/html/guix-devel/2016-11/msg00922.html ok =20 =20 Shouldn???t it be a single comma in @uref? =20 I don't think so. The Texinfo manual suggests, that in this case, the seco= nd arg should be empty. =20 > (define (validate-configuration config fields) > (for-each (lambda (field) > (let ((val ((configuration-field-getter field) config= ))) > - (unless ((configuration-field-predicate field) val) > + (unless (or (not val) ((configuration-field-predica= te field) val)) > (configuration-field-error > (configuration-field-name field) val)))) =20 Here you???re assuming that when VAL is #f, it???s necessary invalid, = an assumption that???s questionable and wasn???t made until now. No. I'm assuming the exact opposite, namely, that #f is a *valid* value. =20 Can you instead change your own field predicate to do that? I could do that, but then I'd be defining a lot of them which are substanti= ally=20 identical to existing ones - and below, you say that you don't want me to= =20 duplicate code ... =20 > + > +(define (serialize-non-negative-integer field-name val) > + (if val > + (serialize-field* field-name val))) > + > +(define (serialize-integer field-name val) > + (if val > + (serialize-field* field-name val)) =20 No ???else??? here? Looks like a bug. No. The idea is, that if fields are #f then they output absolutely nothing. =20 How much of this is copied from configuration.scm? I don???t want duplicated code here. Much of it was copied, but modified where appropriate. None is identical I don't think. =20 J' =20 --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlg+17EACgkQimdxnC3oJ7O5YQCfek0TWle5CYhHRIfMZ2+TfdYW wWsAoIKmacBH4l+eNc1Nqtbpc9pXBH4r =4aS6 -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--