From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Allow nfs file systems to be automatically mounted. Date: Sat, 26 Nov 2016 20:33:58 +0100 Message-ID: <20161126193358.GA10000@jocasta.intra> References: <8760nc6et6.fsf@gnu.org> <1480152990-7080-1-git-send-email-jmd@gnu.org> <87fumenl44.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAijo-0000yK-DN for guix-devel@gnu.org; Sat, 26 Nov 2016 14:34:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAijn-0006cK-BA for guix-devel@gnu.org; Sat, 26 Nov 2016 14:34:16 -0500 Content-Disposition: inline In-Reply-To: <87fumenl44.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic Court??s Cc: guix-devel@gnu.org, John Darrington --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 26, 2016 at 07:37:15PM +0100, Ludovic Court??s wrote: John Darrington skribis: =20 > * gnu/build/file-systems.scm (mount-file-system): Append target addr= =3D when > mounting nfs filesystems. =20 Looks like you forgot to address some of suggestions I made (???string-prefix????,=20 Ok. I will make that change. ???match???,=20 Have another look: + (let* ((host (match (string-split source #\:) ((h _= ) h))) and left a question unanswered (port number?): Sorry. The answer is, no so far as I'm aware, there is no convention which= =20 allows a port number to be specifed in the source field. , etc) The only other thing I think you mentioned was using "if" instead of "cond". I can envisage that in the future there will be a need for other cases, -= =20 it's not just an either/or choice - so it seemed to me that cond was more= =20 appropriate. =20 I am aware there is room for improvement in this patch (for example in the= =20 case of IP6 addresses?) - any help will be gratefully accepted. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlg546YACgkQimdxnC3oJ7PMGwCfULt/Ja7fyvtBmzOKCJnbn/jW lhoAn3oXZiFZ1kX9bFB4fmUNyTSUioiY =2+jx -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q--