unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] Gst-plugins-good security update
Date: Sat, 26 Nov 2016 12:54:17 -0500	[thread overview]
Message-ID: <20161126175417.GA30134@jasmine> (raw)
In-Reply-To: <87fumehbe5.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Sat, Nov 26, 2016 at 09:51:30AM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > The CVE bug fixes are not split into discrete patches, so it doesn't
> > work to make patches for each CVE ID, like we normally do.
> >
> > Is this approach (concatenating the patches) okay?
> 
> I prefer having them separately, so the upstream commit can be clearly
> referenced in the patch header; and they can be reviewed and modified
> independently.
> 
> In this instance it's okay, since I just checked out the 1.10 branch and
> concatenated the four commits and ended up with the same patch :-)
> 
> That's not to say it should not be allowed. I think this approach is
> fine for long patch series, but at only four patches it's not the best
> precedent.

I wondered how to split the patches up here. I don't know how to name
the first two patches, since the CVE bug fixes are spread between them.

I'll break the 3 and 4th patch off into their own files.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2016-11-26 17:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  7:11 [PATCH 0/1] Gst-plugins-good security update Leo Famulari
2016-11-25  7:11 ` [PATCH 1/1] gnu: gst-plugins-good: Fix CVE-2016-{9634,9635,9636} Leo Famulari
2016-11-26  8:51 ` [PATCH 0/1] Gst-plugins-good security update Marius Bakke
2016-11-26 17:54   ` Leo Famulari [this message]
2016-11-26 17:58     ` Marius Bakke
2016-11-26 19:38   ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161126175417.GA30134@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).