unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH v4 3/3] gnu: Add kicad.
Date: Fri, 25 Nov 2016 00:40:51 -0500	[thread overview]
Message-ID: <20161125054051.GA30271@jasmine> (raw)
In-Reply-To: <874m2zi9is.fsf@openmailbox.org>

On Tue, Nov 22, 2016 at 09:46:17PM +0200, Theodoros Foradis wrote:
> 
> Leo Famulari writes:
> 
> > On Mon, Nov 07, 2016 at 08:16:28PM +0200, Theodoros Foradis wrote:
> >> * gnu/packages/engineering.scm (kicad): New variable.
> >
> > There are some comments about minor issues on this version 3 of the
> > patch series. I can address these myself before pushing if there are no
> > more comments. I will read the patches one more time, test the build,
> > and push tomorrow if there are no more comments.
> >
> > Thanks to everyone who was worked on this! It's a big group :)
> 
> Hello,
> 
> I have posted a version 5 of the patch series, which I have not
> commented on. It (hopefully) includes the fixes, based on the comments
> on previous patch series.
> 
> It contains an extra patch, with the kicad-library package, which
> includes components, footprints and 3D models for kicad.

I fixed some minor cosmetic issues (long lines, indentation, etc) and
also made some minor edits to descriptions and comments, and pushed the
v5 patch series, ending with 8f528bd4426fdb3e6e571316b185e70d30485c7e.

Thanks a lot everyone!

  reply	other threads:[~2016-11-25  5:41 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 21:16 [PATCH 0/3] gnu: Add kicad Theodoros Foradis
2016-10-24 21:16 ` [PATCH 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-10-24 21:16 ` [PATCH 2/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25  8:32   ` Hartmut Goebel
2016-10-25  9:58     ` Theodoros Foradis
2016-10-25 16:20   ` Efraim Flashner
2016-10-24 21:16 ` [PATCH 3/3] gnu: Add kicad Theodoros Foradis
2016-10-25  0:36   ` Leo Famulari
2016-10-25  0:41     ` Leo Famulari
2016-10-25  8:11       ` Theodoros Foradis
2016-10-25 12:48   ` Leo Famulari
2016-10-25 16:09     ` [PATCH v2 0/3] " Theodoros Foradis
2016-10-25 16:09       ` [PATCH v2 1/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25 16:32         ` Leo Famulari
2016-10-25 16:09       ` [PATCH v2 2/3] gnu: Add kicad Theodoros Foradis
2016-10-25 16:09       ` [PATCH v2 3/3] gnu: Add python2-wxpython Theodoros Foradis
2016-10-25 16:35         ` Leo Famulari
2016-10-25 17:13           ` Theodoros Foradis
2016-10-30  0:13             ` Leo Famulari
2016-10-30 10:13               ` Hartmut Goebel
2016-10-31 10:42               ` Danny Milosavljevic
2016-10-31 15:38                 ` Danny Milosavljevic
2016-10-25 18:05           ` Theodoros Foradis
2016-10-25 18:28             ` Leo Famulari
2016-10-25 16:59       ` [PATCH v3 0/3] gnu: Add kicad Theodoros Foradis
2016-10-25 16:59         ` [PATCH v3 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-02  8:15           ` Danny Milosavljevic
2016-10-25 17:00         ` [PATCH v3 2/2] gnu: Add python2-wxpython Theodoros Foradis
2016-11-02  7:57           ` Danny Milosavljevic
2016-11-02 13:53             ` Theodoros Foradis
2016-10-25 17:00         ` [PATCH v3 3/3] gnu: Add kicad Theodoros Foradis
2016-10-30  0:18           ` Leo Famulari
2016-11-02 15:42             ` Theodoros Foradis
2016-11-05 18:41               ` Leo Famulari
2016-11-07 18:16                 ` [PATCH v4 1/3] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-07 18:16                   ` [PATCH v4 2/3] gnu: Add python2-wxpython Theodoros Foradis
2016-11-07 22:38                     ` Danny Milosavljevic
2016-11-07 18:16                   ` [PATCH v4 3/3] gnu: Add kicad Theodoros Foradis
2016-11-07 18:47                     ` Efraim Flashner
2016-11-15 20:53                       ` [PATCH v5 1/4] gnu: Add wxwidgets-gtk2 Theodoros Foradis
2016-11-15 20:53                         ` [PATCH v5 2/4] gnu: Add python2-wxpython Theodoros Foradis
2016-11-15 20:53                         ` [PATCH v5 3/4] gnu: Add kicad Theodoros Foradis
2016-11-15 20:53                         ` [PATCH v5 4/4] gnu: Add kicad-library Theodoros Foradis
2016-11-15 19:26                     ` [PATCH v4 3/3] gnu: Add kicad Leo Famulari
2016-11-22 19:46                       ` Theodoros Foradis
2016-11-25  5:40                         ` Leo Famulari [this message]
2016-11-07 21:04                 ` [PATCH v3 " Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161125054051.GA30271@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=theodoros.for@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).