From: Leo Famulari <leo@famulari.name>
To: Petter <petter@mykolab.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Added package xcalib
Date: Sat, 19 Nov 2016 13:36:52 -0500 [thread overview]
Message-ID: <20161119183652.GA18749@jasmine> (raw)
In-Reply-To: <17b0d56c8b2baf7fd52212ec829860ff@mykolab.ch>
On Sat, Nov 19, 2016 at 06:14:32PM +0100, Petter wrote:
> On 2016-11-18 21:10, Leo Famulari wrote:
> > (install-file) does (mkdir-p) itself, so I removed the redundant
> > (mkdir-p). It's defined in (guix build utils) if you are interested to
> > see.
>
> Ok. I looked it up in another package, and copied the approach. (I see this
> redundancy occurs in several other places.)
Feel free to submit patches fixing those redundancies!
> Thanks for doing the final touches! And I really appreciate your detailed
> explanations! The next patch should hopefully be less of a burden on you
> reviewers :)
That's my plan :)
prev parent reply other threads:[~2016-11-19 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 16:05 [PATCH] Added package xcalib Petter
2016-11-15 19:35 ` Leo Famulari
2016-11-16 0:37 ` Petter
2016-11-18 20:10 ` Leo Famulari
2016-11-19 17:14 ` Petter
2016-11-19 18:36 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119183652.GA18749@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=petter@mykolab.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).