unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: mpop: Update to 1.2.6.
Date: Thu, 17 Nov 2016 16:09:09 -0500	[thread overview]
Message-ID: <20161117210909.GB5556@jasmine> (raw)
In-Reply-To: <8737ipdec1.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

On Thu, Nov 17, 2016 at 09:46:38PM +0100, Marius Bakke wrote:
> Arun Isaac <arunisaac@systemreboot.net> writes:
> > Marius Bakke writes:
> >
> >> Thanks for this. I'm unable to download the new version with
> >> `./pre-inst-env guix build mpop`;
> >
> > Not sure what the problem is. I was able to build mpop successfully on
> > my system. But, I did download manually with `guix download'
> > first. Perhaps the build used that downloaded source tarball.

I fixed the URL and made it use our SourceForge mirror in commit
5837e6993.

> Yes, if the hash already exists in the store, it will be used instead of
> downloading.  This has caused some confusion before :-)

As Marius hints at, using `guix download` to get source code while
writing a package masks errors in the package's URL. You should always
download the source code "out of band" with wget, curl, a web browser,
etc, and then use `guix hash` to calculate the hash.

That way, you can be sure the package works.

Also, you don't leak information (via `guix download`'s network
signature) to potentially hostile servers that you are packaging
software for Guix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2016-11-17 21:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 11:43 [PATCH] gnu: mpop: Update to 1.2.6 Arun Isaac
2016-11-17 16:46 ` Marius Bakke
2016-11-17 19:46   ` Arun Isaac
2016-11-17 20:46     ` Marius Bakke
2016-11-17 21:09       ` Leo Famulari [this message]
2016-11-19  2:24         ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161117210909.GB5556@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).